GH#18538: worker-is-triager model for review-followup issues (follow-up to #18610)

[marcusquinn]

Summary

Flips SCANNER_NEEDS_REVIEW default from true to false and rewrites the issue-body preamble as worker-facing triage instructions mandating three outcomes: (A) premise falsified → close with rationale, (B) premise correct + fix obvious → implement and PR, (C) premise correct but genuinely ambiguous → post decision comment with analysis + recommendation + specific question, then escalate. Humans approve, they don't re-do analysis. PR #18610 applied needs-maintainer-review unconditionally at issue creation — that was the exact 'punt analysis to a human' anti-pattern prompts/build.txt 'Reasoning responsibility' forbids at the reasoning layer, applied to the dispatch layer instead.

Files Changed

.agents/scripts/post-merge-review-scanner.sh

Runtime Testing

• Risk level: Low (agent prompts / infrastructure scripts)
• Verification: shellcheck -S warning clean; bash -n parse OK; isolated body-builder smoke test renders all three outcome paths with correct placeholder.

Resolves #18538

---

aidevops.sh v3.8.8 plugin for OpenCode v1.4.3 with claude-sonnet-4-6 spent 17h 38m and 8,145 tokens on this as a headless worker.

[marcusquinn]

Completion Summary

• What: Flips SCANNER_NEEDS_REVIEW default from true to false and rewrites the issue-body preamble as worker-facing triage instructions mandating three outcomes: (A) premise falsified → close with rationale, (B) premise correct + fix obvious → implement and PR, (C) premise correct but genuinely ambiguous → post decision comment with analysis + recommendation + specific question, then escalate. Humans approve, they don't re-do analysis. PR GH#18538: gate review-followup issues on human triage (complement to #18607) #18610 applied needs-maintainer-review unconditionally at issue creation — that was the exact 'punt analysis to a human' anti-pattern prompts/build.txt 'Reasoning responsibility' forbids at the reasoning layer, applied to the dispatch layer instead.
• Issue: Review followup: PR #18417 — chore(t1990): add TODO completion marker for merged PR #18414 #18538
• Files changed: .agents/scripts/post-merge-review-scanner.sh
• Testing: shellcheck -S warning clean; bash -n parse OK; isolated body-builder smoke test renders all three outcome paths with correct placeholder.
• Key decisions: Kept SCANNER_NEEDS_REVIEW env var as an opt-in escape hatch (default false) rather than deleting it entirely, so pipelines that DO need unconditional human sign-off still have a knob. Origin:worker hardcoding from GH#18670 preserved. The worker-is-triager rule is carried by the issue body's worker-facing preamble, not a label — the label was the wrong enforcement mechanism.

[gemini-code-assist]

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

[coderabbitai]

Warning

Rate limit exceeded

@marcusquinn has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 36 minutes and 56 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 36 minutes and 56 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 685fd5f1-b1d5-4d0b-ad53-ff4093356a4b

📥 Commits

Reviewing files that changed from the base of the PR and between 560a911 and 08e3dbd.

📒 Files selected for processing (1)

• .agents/scripts/post-merge-review-scanner.sh

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feature/gh18538-worker-is-triager

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

🔍 Code Quality Report

�[0;35m[MONITOR]�[0m Code Review Monitoring Report

SonarCloud: 0 bugs, 0 vulnerabilities, 226 code smells

Mon Apr 13 22:11:08 UTC 2026: Code review monitoring started
Mon Apr 13 22:11:08 UTC 2026: SonarCloud - Bugs: 0, Vulnerabilities: 0, Code Smells: 226

📈 Current Quality Metrics

• BUGS: 0
• CODE SMELLS: 226
• VULNERABILITIES: 0

Generated on: Mon Apr 13 22:11:11 UTC 2026

---

Generated by AI DevOps Framework Code Review Monitoring

[codacy-production]

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

_{TIP This summary will be updated as you push new changes. Give us feedback}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud