t1312: Remove dead code stubs + retire evaluate_worker heuristic tree#2221
t1312: Remove dead code stubs + retire evaluate_worker heuristic tree#2221marcusquinn merged 1 commit intomainfrom
Conversation
…stic tree Delete lifecycle.sh (102 lines) and git-ops.sh (91 lines) — all functions were no-op stubs, never called. Remove evaluate_worker() (687 lines), evaluate_with_ai() (251 lines), and evaluate_worker_with_metadata() (58 lines) from evaluate.sh. These formed a deterministic heuristic tree for worker evaluation. Replaced by assess_task_with_metadata() in assess-task.sh (AI-powered, already the preferred path in pulse.sh since it was added). Update pulse.sh to call assess_task_with_metadata() directly instead of the 3-tier fallback chain. Update cmd_evaluate CLI to use the AI path. Update comment references across dispatch.sh and deploy.sh. Net: -977 lines (1,008 deleted, 31 added)
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (7)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🔍 Code Quality Report�[0;35m[MONITOR]�[0m Code Review Monitoring Report �[0;34m[INFO]�[0m Latest Quality Status: �[0;34m[INFO]�[0m Recent monitoring activity: 📈 Current Quality Metrics
Generated on: Tue Feb 24 17:25:18 UTC 2026 Generated by AI DevOps Framework Code Review Monitoring |
Summary of ChangesHello @marcusquinn, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on removing dead code and replacing a deterministic heuristic tree with an AI-powered task assessment system. This change simplifies the evaluation process and reduces the codebase size, while also improving the accuracy and efficiency of task assessments. Highlights
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request successfully removes dead code stubs and transitions the task evaluation to an AI-powered approach. The changes are well-documented within the code comments, clearly indicating the removal of the old heuristic tree and the adoption of assess_task_with_metadata(). The updates in deploy.sh, dispatch.sh, and pulse.sh correctly reflect this change, ensuring consistency across the supervisor scripts. The overall impact is a significant reduction in code lines and a move towards a more modern, AI-driven evaluation system. The removal of lifecycle.sh and git-ops.sh stubs is also a good cleanup, as they were unused.
…hived pulse.sh The heartbeat_window arithmetic at line 230 would emit a bash arithmetic error if SUPERVISOR_EVAL_TIMEOUT is set to a non-integer value (e.g. '90s'). Add a regex guard that defaults to 90 and logs a warning when the value is non-numeric. Note: the critical evaluate.sh heartbeat cleanup scope bug (the other finding from issue #3364 / PR #1958 review) was already resolved — evaluate_with_ai() containing the buggy push_cleanup/save_cleanup_scope ordering was deleted in PR #2221 (t1312 dead code removal) before the supervisor was archived in PR #2291. No change needed to evaluate.sh. Shellcheck: evaluate.sh passes clean (0 violations). pulse.sh passes bash -n syntax check; shellcheck OOMs on the 3983-line archived file (pre-existing, unrelated to this change). Closes #3364
…e.sh PR #1958 review feedback (CodeRabbit nitpick): arithmetic expansion on heartbeat_window fails if SUPERVISOR_EVAL_TIMEOUT is set to a non-integer (e.g. '90s'). Add a regex guard that defaults to 90 and logs a warning when the value is non-numeric. Note: the critical finding (heartbeat cleanup scope ordering in evaluate.sh) was already resolved by t1312 (PR #2221), which removed the heartbeat/watchdog code entirely from the active supervisor path before archiving. Closes #3364
…hived pulse.sh (#4572) The heartbeat_window arithmetic at line 230 would emit a bash arithmetic error if SUPERVISOR_EVAL_TIMEOUT is set to a non-integer value (e.g. '90s'). Add a regex guard that defaults to 90 and logs a warning when the value is non-numeric. Note: the critical evaluate.sh heartbeat cleanup scope bug (the other finding from issue #3364 / PR #1958 review) was already resolved — evaluate_with_ai() containing the buggy push_cleanup/save_cleanup_scope ordering was deleted in PR #2221 (t1312 dead code removal) before the supervisor was archived in PR #2291. No change needed to evaluate.sh. Shellcheck: evaluate.sh passes clean (0 violations). pulse.sh passes bash -n syntax check; shellcheck OOMs on the 3983-line archived file (pre-existing, unrelated to this change). Closes #3364
…e.sh PR #1958 review feedback (CodeRabbit nitpick): arithmetic expansion on heartbeat_window fails if SUPERVISOR_EVAL_TIMEOUT is set to a non-integer (e.g. '90s'). Add a regex guard that defaults to 90 and logs a warning when the value is non-numeric. Note: the critical finding (heartbeat cleanup scope ordering in evaluate.sh) was already resolved by t1312 (PR #2221), which removed the heartbeat/watchdog code entirely from the active supervisor path before archiving. Closes #3364
…e.sh (#4581) PR #1958 review feedback (CodeRabbit nitpick): arithmetic expansion on heartbeat_window fails if SUPERVISOR_EVAL_TIMEOUT is set to a non-integer (e.g. '90s'). Add a regex guard that defaults to 90 and logs a warning when the value is non-numeric. Note: the critical finding (heartbeat cleanup scope ordering in evaluate.sh) was already resolved by t1312 (PR #2221), which removed the heartbeat/watchdog code entirely from the active supervisor path before archiving. Closes #3364
…hived pulse.sh (#4572) The heartbeat_window arithmetic at line 230 would emit a bash arithmetic error if SUPERVISOR_EVAL_TIMEOUT is set to a non-integer value (e.g. '90s'). Add a regex guard that defaults to 90 and logs a warning when the value is non-numeric. Note: the critical evaluate.sh heartbeat cleanup scope bug (the other finding from issue #3364 / PR #1958 review) was already resolved — evaluate_with_ai() containing the buggy push_cleanup/save_cleanup_scope ordering was deleted in PR #2221 (t1312 dead code removal) before the supervisor was archived in PR #2291. No change needed to evaluate.sh. Shellcheck: evaluate.sh passes clean (0 violations). pulse.sh passes bash -n syntax check; shellcheck OOMs on the 3983-line archived file (pre-existing, unrelated to this change). Closes #3364
…e.sh (#4581) PR #1958 review feedback (CodeRabbit nitpick): arithmetic expansion on heartbeat_window fails if SUPERVISOR_EVAL_TIMEOUT is set to a non-integer (e.g. '90s'). Add a regex guard that defaults to 90 and logs a warning when the value is non-numeric. Note: the critical finding (heartbeat cleanup scope ordering in evaluate.sh) was already resolved by t1312 (PR #2221), which removed the heartbeat/watchdog code entirely from the active supervisor path before archiving. Closes #3364
… quality-debt) (#4582) * fix(t3364): add numeric validation for SUPERVISOR_EVAL_TIMEOUT in archived pulse.sh (#4572) The heartbeat_window arithmetic at line 230 would emit a bash arithmetic error if SUPERVISOR_EVAL_TIMEOUT is set to a non-integer value (e.g. '90s'). Add a regex guard that defaults to 90 and logs a warning when the value is non-numeric. Note: the critical evaluate.sh heartbeat cleanup scope bug (the other finding from issue #3364 / PR #1958 review) was already resolved — evaluate_with_ai() containing the buggy push_cleanup/save_cleanup_scope ordering was deleted in PR #2221 (t1312 dead code removal) before the supervisor was archived in PR #2291. No change needed to evaluate.sh. Shellcheck: evaluate.sh passes clean (0 violations). pulse.sh passes bash -n syntax check; shellcheck OOMs on the 3983-line archived file (pre-existing, unrelated to this change). Closes #3364 * fix: guard SUPERVISOR_EVAL_TIMEOUT against non-numeric values in pulse.sh (#4581) PR #1958 review feedback (CodeRabbit nitpick): arithmetic expansion on heartbeat_window fails if SUPERVISOR_EVAL_TIMEOUT is set to a non-integer (e.g. '90s'). Add a regex guard that defaults to 90 and logs a warning when the value is non-numeric. Note: the critical finding (heartbeat cleanup scope ordering in evaluate.sh) was already resolved by t1312 (PR #2221), which removed the heartbeat/watchdog code entirely from the active supervisor path before archiving. Closes #3364 --------- Co-authored-by: alex-solovyev <1556417+alex-solovyev@users.noreply.github.com>
1 participant
Summary
lifecycle.sh(102 lines) andgit-ops.sh(91 lines) — all functions were no-op stubs, never calledevaluate_worker()(687 lines),evaluate_with_ai()(251 lines), andevaluate_worker_with_metadata()(58 lines) fromevaluate.sh— deterministic heuristic tree replaced by AI-poweredassess_task_with_metadata()inassess-task.shpulse.shto callassess_task_with_metadata()directly (remove 3-tier fallback chain)cmd_evaluateCLI, comment references indispatch.shanddeploy.shNet: -977 lines (1,008 deleted, 31 added)
Part of t1311 (Supervisor AI-first migration). Closes #2208.