Skip to content

t1359: Mission-aware browser QA in milestone validation#2540

Closed
marcusquinn wants to merge 1 commit intomainfrom
feature/t1359-browser-qa-milestone-validation
Closed

t1359: Mission-aware browser QA in milestone validation#2540
marcusquinn wants to merge 1 commit intomainfrom
feature/t1359-browser-qa-milestone-validation

Conversation

@marcusquinn
Copy link
Copy Markdown
Owner

@marcusquinn marcusquinn commented Feb 28, 2026

Summary

  • Add Playwright-based visual testing pipeline for mission milestone validation with browser-qa-helper.sh (smoke tests, multi-viewport screenshots, broken link crawling, WCAG accessibility checks)
  • Create browser-qa.md subagent doc with severity mapping, pipeline steps, and visual regression guidance
  • Extend existing milestone-validation.md (from t1357.6) with browser QA pipeline integration, "How to Think" section, and severity classification table
  • Wire into mission orchestrator Phase 4 and browser automation decision tree

Changes

File What
scripts/browser-qa-helper.sh New — CLI: run, screenshot, links, a11y, smoke commands (912 lines)
tools/browser/browser-qa.md New — Subagent doc: severity mapping, 6-step pipeline, visual regression
workflows/milestone-validation.md Extended — Added browser QA section, severity table, dev server mgmt, "How to Think"
workflows/mission-orchestrator.md Updated — Phase 4 references browser QA pipeline, Related section expanded
tools/browser/browser-automation.md Updated — Decision tree extended with QA branch
AGENTS.md Updated — Domain index includes browser-qa entry
subagent-index.toon Updated — Index entries for browser-qa and milestone-validation

Verification

  • ShellCheck: 0 violations on browser-qa-helper.sh
  • Markdown lint: clean on all .md files
  • Script is executable (mode 755)
  • All shared-constants.sh dependencies verified (logging, error constants)
  • Rebased onto latest main, merge conflicts resolved cleanly

Closes #2503

Add Playwright-based visual testing pipeline for mission milestone
validation. Creates browser-qa-helper.sh (smoke tests, screenshots,
broken link detection, accessibility checks), browser-qa.md subagent
doc, and milestone-validation.md workflow. Integrates with existing
browser automation stack and mission orchestrator Phase 4.
@gemini-code-assist
Copy link
Copy Markdown

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Feb 28, 2026

Warning

Rate limit exceeded

@marcusquinn has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 7 minutes and 55 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 8fd509f and 6c2be4a.

📒 Files selected for processing (7)
  • .agents/AGENTS.md
  • .agents/scripts/browser-qa-helper.sh
  • .agents/subagent-index.toon
  • .agents/tools/browser/browser-automation.md
  • .agents/tools/browser/browser-qa.md
  • .agents/workflows/milestone-validation.md
  • .agents/workflows/mission-orchestrator.md
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/t1359-browser-qa-milestone-validation

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@marcusquinn
Copy link
Copy Markdown
Owner Author

Duplicate of #2541 — both PRs implement t1359 (issue #2503) on different branches. #2541 (feature/browser-qa-worker) is the more complete implementation and will be merged. Closing this one in favour of #2541.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

t1359: Mission-aware browser QA in milestone validation

1 participant