Skip to content

GH#3702: Fix critical quality-debt in code-audit-helper.sh#3720

Merged
marcusquinn merged 1 commit intomainfrom
bugfix/code-audit-quality-debt-3702
Mar 8, 2026
Merged

GH#3702: Fix critical quality-debt in code-audit-helper.sh#3720
marcusquinn merged 1 commit intomainfrom
bugfix/code-audit-quality-debt-3702

Conversation

@marcusquinn
Copy link
Copy Markdown
Owner

Summary

  • Numeric validation: Added integer sanitisation for all jq-parsed API values (total, critical, high, medium, low) before SQL interpolation and bash arithmetic — prevents SQL syntax errors and arithmetic failures from malformed SonarCloud API responses
  • DB query consolidation: Replaced three separate SELECT queries for the previous regression snapshot with a single query returning all columns via pipe-separated output, reducing DB round-trips

Context

Addresses critical and major findings from CodeRabbit review on PR #1418:

  1. Duplicate check-regression case arm (dead code) — already fixed in current code
  2. Numeric validation (major) — API-derived values interpolated into SQL without validation
  3. DB query consolidation (nitpick) — three queries for the same row
  4. unified_task_creator variable reuse in pulse.sh — pulse.sh is archived, not applicable

Closes #3702

…solidate DB queries

Sanitise jq-parsed values with integer validation before SQL interpolation
and arithmetic, preventing syntax errors from malformed SonarCloud API
responses. Consolidate three separate DB queries for previous snapshot
into a single query returning all columns.

Closes #3702
@gemini-code-assist
Copy link
Copy Markdown

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 7, 2026

Warning

Rate limit exceeded

@marcusquinn has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 5 minutes and 56 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 70fd4711-b493-4fca-80f0-adf3a840ead3

📥 Commits

Reviewing files that changed from the base of the PR and between d64428e and f6f6dbb.

📒 Files selected for processing (1)
  • .agents/scripts/code-audit-helper.sh
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch bugfix/code-audit-quality-debt-3702

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 7, 2026

🔍 Code Quality Report

�[0;35m[MONITOR]�[0m Code Review Monitoring Report

�[0;34m[INFO]�[0m Latest Quality Status:
SonarCloud: 0 bugs, 0 vulnerabilities, 125 code smells

�[0;34m[INFO]�[0m Recent monitoring activity:
Sat Mar 7 21:22:10 UTC 2026: Code review monitoring started
Sat Mar 7 21:22:11 UTC 2026: SonarCloud - Bugs: 0, Vulnerabilities: 0, Code Smells: 125

📈 Current Quality Metrics

  • BUGS: 0
  • CODE SMELLS: 125
  • VULNERABILITIES: 0

Generated on: Sat Mar 7 21:22:13 UTC 2026


Generated by AI DevOps Framework Code Review Monitoring

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Mar 7, 2026

@marcusquinn
Copy link
Copy Markdown
Owner Author

@coderabbitai review

Review bots were rate-limited when this PR was created (affected: coderabbitai gemini-code-assist). Requesting a review retry.

@gemini-code-assist
Copy link
Copy Markdown

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 7, 2026

@marcusquinn: Sure! Kicking off a fresh review of PR #3720 now. 🚀


🧠 Learnings used
Learnt from: marcusquinn
Repo: marcusquinn/aidevops PR: 0
File: :0-0
Timestamp: 2026-03-03T16:33:18.313Z
Learning: For the marcusquinn/aidevops repository: The daily quality sweep system (pulse-wrapper.sh) should only mention coderabbitai for full codebase review when there are significant changes (Quality Gate failure, +10 issues in one day, etc.), not on every automated sweep with stable metrics.
✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@marcusquinn
Copy link
Copy Markdown
Owner Author

This PR appears orphaned — no active worker process found and no activity for 7+ hours. Flagging for re-dispatch.

@marcusquinn marcusquinn added the status:orphaned Worker died, issue needs recovery label Mar 8, 2026
@marcusquinn
Copy link
Copy Markdown
Owner Author

This PR appears orphaned — no active worker process found and no activity for 14+ hours. Flagging for re-dispatch. If work is still in progress, remove the status:orphaned label.

@marcusquinn
Copy link
Copy Markdown
Owner Author

Merging via pulse supervisor.

@marcusquinn marcusquinn merged commit 724e94e into main Mar 8, 2026
19 checks passed
@marcusquinn marcusquinn deleted the bugfix/code-audit-quality-debt-3702 branch March 8, 2026 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

quality-debt: PR #1418 review feedback (critical)

1 participant