GH#3750: Fix SQL injection and Codacy API endpoint in quality-sweep-helper.sh#3968
GH#3750: Fix SQL injection and Codacy API endpoint in quality-sweep-helper.sh#3968marcusquinn merged 1 commit intomainfrom
Conversation
…quality-sweep-helper.sh Closes #3750 - Add input validation for --limit flag in cmd_sonarcloud_query, cmd_codacy_query, and cmd_dedup to reject non-numeric values before they reach SQL LIMIT clauses - Fix Codacy API endpoint: add missing /search suffix to the issues endpoint per Codacy v3 API requirements
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
|
Important Review skippedAuto reviews are limited based on label configuration. 🚫 Review skipped — only excluded labels are configured. (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🔍 Code Quality Report�[0;35m[MONITOR]�[0m Code Review Monitoring Report �[0;34m[INFO]�[0m Latest Quality Status: �[0;34m[INFO]�[0m Recent monitoring activity: 📈 Current Quality Metrics
Generated on: Mon Mar 9 07:29:46 UTC 2026 Generated by AI DevOps Framework Code Review Monitoring |
|



Summary
--limitflag as a positive integer (^[1-9][0-9]*$) before interpolation into SQLLIMITclauses incmd_sonarcloud_query,cmd_codacy_query, andcmd_dedup. Previously, non-numeric values passed via--limitwere interpolated directly into sqlite3 queries, allowing SQL injection./searchsuffix to the Codacy v3 issues endpoint (/analysis/organizations/{provider}/{org}/repositories/{repo}/issues→.../issues/search), which is required by the Codacy v3 API.Both findings were identified by CodeRabbit in PR #1000 review.
Closes #3750