GH#3587: fix critical quality-debt in fluentcrm.json#4337
Conversation
…tructions The @netflyapp/fluentcrm-mcp-server package is not published on npm, so npx would fail at runtime. The command was already fixed to use a local node path. This commit adds top-level _comment, _setup, _env, and _docs fields to make the build requirement explicit and self-documenting, addressing the critical CodeRabbit finding from PR marcusquinn#64 review. Closes marcusquinn#3587
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
Important Review skippedAuto reviews are limited based on label configuration. 🚫 Review skipped — only excluded labels are configured. (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Closes #3587
Addresses the critical CodeRabbit finding from PR #64 review:
@netflyapp/fluentcrm-mcp-serverdoes not exist on the npm registry, making the originalnpxcommand non-functional at runtime.Changes
configs/mcp-templates/fluentcrm.json_commentexplicitly noting the npm package is not published and a local build is required_setupfield with the exactgit clone+npm install+npm run buildcommand sequence_envfield documenting the required environment variables (FLUENTCRM_API_URL,FLUENTCRM_API_USERNAME,FLUENTCRM_API_PASSWORD)_docsfield pointing to.agents/services/crm/fluentcrm.md_commentto reference the top-level_setupfield for claritynode ~/.local/share/mcp-servers/fluentcrm-mcp-server/dist/fluentcrm-mcp-server.jscommand (fixed in PR feat(crm): add FluentCRM MCP integration for sales and marketing #64 commit a43e412) and"enabled": falsedefaultVerification
enabled: falsepreserved — template remains safe to copy without accidental activation ✅ahrefs-seo.json,twilio.json) that document setup inline ✅