Skip to content

GH#3587: fix critical quality-debt in fluentcrm.json#4337

Merged
alex-solovyev merged 1 commit intomarcusquinn:mainfrom
alex-solovyev:bugfix/GH-3587-fluentcrm-quality-debt
Mar 13, 2026
Merged

GH#3587: fix critical quality-debt in fluentcrm.json#4337
alex-solovyev merged 1 commit intomarcusquinn:mainfrom
alex-solovyev:bugfix/GH-3587-fluentcrm-quality-debt

Conversation

@alex-solovyev
Copy link
Copy Markdown
Collaborator

Summary

Closes #3587

Addresses the critical CodeRabbit finding from PR #64 review: @netflyapp/fluentcrm-mcp-server does not exist on the npm registry, making the original npx command non-functional at runtime.

Changes

configs/mcp-templates/fluentcrm.json

  • Adds top-level _comment explicitly noting the npm package is not published and a local build is required
  • Adds _setup field with the exact git clone + npm install + npm run build command sequence
  • Adds _env field documenting the required environment variables (FLUENTCRM_API_URL, FLUENTCRM_API_USERNAME, FLUENTCRM_API_PASSWORD)
  • Adds _docs field pointing to .agents/services/crm/fluentcrm.md
  • Updates the inner _comment to reference the top-level _setup field for clarity
  • Retains the already-correct node ~/.local/share/mcp-servers/fluentcrm-mcp-server/dist/fluentcrm-mcp-server.js command (fixed in PR feat(crm): add FluentCRM MCP integration for sales and marketing #64 commit a43e412) and "enabled": false default

Verification

  • JSON syntax validated ✅
  • enabled: false preserved — template remains safe to copy without accidental activation ✅
  • Setup instructions are self-contained in the template file ✅
  • Consistent with other templates (e.g., ahrefs-seo.json, twilio.json) that document setup inline ✅

…tructions

The @netflyapp/fluentcrm-mcp-server package is not published on npm, so
npx would fail at runtime. The command was already fixed to use a local
node path. This commit adds top-level _comment, _setup, _env, and _docs
fields to make the build requirement explicit and self-documenting,
addressing the critical CodeRabbit finding from PR marcusquinn#64 review.

Closes marcusquinn#3587
@gemini-code-assist
Copy link
Copy Markdown

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 13, 2026

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)
  • no-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: d9687ab3-710f-436a-9d25-8b6dbe321814

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Auto-created from TODO.md tag

Projects

None yet

Development

Successfully merging this pull request may close these issues.

quality-debt: configs/mcp-templates/fluentcrm.json — PR #64 review feedback (critical)

1 participant