t1542: fix: add 14 orphaned archived scripts to cleanup_deprecated_paths()

[alex-solovyev]

Summary

• Adds 14 orphaned archived scripts to the deprecated_paths array in cleanup_deprecated_paths() (setup-modules/migrations.sh)
• Follow-up to PR GH#5147: Clean up orphaned supervisor-helper.sh and supervisor/ during update #5151 which handled supervisor-helper.sh and supervisor/ directory
• On next aidevops update, these orphaned files will be cleaned up from ~/.aidevops/agents/scripts/

Problem

After scripts were archived upstream, aidevops update (rsync) only adds/overwrites — it doesn't delete files removed from the source. Users who installed before the archival retain 14 orphaned scripts:

pattern-tracker-helper.sh, quality-sweep-helper.sh, quality-loop-helper.sh, review-pulse-helper.sh, self-improve-helper.sh, coderabbit-pulse-helper.sh, coderabbit-task-creator-helper.sh, audit-task-creator-helper.sh, batch-cleanup-helper.sh, coordinator-helper.sh, finding-to-task-helper.sh, objective-runner-helper.sh, ralph-loop-helper.sh, stale-pr-helper.sh

Fix

Added all 14 scripts to the existing deprecated_paths array in cleanup_deprecated_paths(), following the exact same pattern used for other deprecated paths in the function. The existing loop already handles removal and counting.

Verification

• shellcheck setup-modules/migrations.sh — 0 violations
• Pattern matches existing entries in the array (simple path addition)

Closes #5155

Summary by CodeRabbit

• Chores
  • Expanded the deprecation cleanup procedure to remove additional obsolete scripts and utilities from previous versions. The enhancement targets pattern tracking, quality assurance, code review, audit, batch processing, coordination utilities, and related helper scripts. This ensures comprehensive removal of outdated code during system maintenance cycles.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses the issue of orphaned script files remaining in user installations after being archived upstream. By extending the deprecated_paths list in the cleanup_deprecated_paths() function, it ensures that 14 specific scripts, which aidevops update previously failed to remove, will now be automatically deleted, improving system hygiene and preventing clutter from unused components.

Highlights

• Deprecated Script Cleanup: Added 14 previously archived scripts to the deprecated_paths array within the cleanup_deprecated_paths() function in setup-modules/migrations.sh.
• Automated Cleanup: These additions ensure that orphaned script files, which were not removed by aidevops update due to its rsync-based behavior, will be properly cleaned up on the next update.
• Follow-up: This change is a direct follow-up to PR GH#5147: Clean up orphaned supervisor-helper.sh and supervisor/ during update #5151, which addressed similar cleanup for supervisor-helper.sh and the supervisor/ directory.

Changelog

• setup-modules/migrations.sh
  • Added 14 specific script paths to the deprecated_paths array within the cleanup_deprecated_paths function.

Activity

• Identified and addressed the problem of 14 orphaned archived scripts not being removed by aidevops update.
• Verified the changes by running shellcheck setup-modules/migrations.sh with 0 violations.
• Confirmed the pattern matches existing entries in the deprecated_paths array.
• Closed issue t1542: fix: aidevops update leaves 14 additional orphaned archived scripts beyond supervisor #5155.
• Followed up on previous work done in PR GH#5147: Clean up orphaned supervisor-helper.sh and supervisor/ during update #5151.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[coderabbitai]

Caution

Review failed

Pull request was closed or merged during review

Walkthrough

Extends the cleanup_deprecated_paths() function in the migrations module to include 14 additional archived helper scripts that were deprecated upstream but remain in active local paths, complementing previous cleanup work for supervisor-related files.

Changes

Cohort / File(s)	Summary
Deprecated Script Cleanup setup-modules/migrations.sh	Added 14 archived helper script paths to cleanup_deprecated_paths(): pattern-tracker, quality-sweep, quality-loop, review-pulse, self-improve, coderabbit-pulse, coderabbit-task-creator, audit-task-creator, batch-cleanup, coordinator, finding-to-task, objective-runner, ralph-loop, and stale-pr helpers. Includes comments documenting archival context.

Estimated Code Review Effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

📦 Fourteen orphaned scripts were found,
Collecting dust on common ground.
A cleanup sweep, both swift and kind,
Leaves zero debt and clutter behind.
The archive flows, the paths align—
A-grade automation, perfectly fine. ✨

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: adding 14 orphaned archived scripts to the cleanup_deprecated_paths() function, matching the PR's core objective.
Linked Issues check	✅ Passed	The PR fully addresses issue #5155 by adding all 14 specified orphaned scripts to cleanup_deprecated_paths() in setup-modules/migrations.sh, ensuring removal on next aidevops update.
Out of Scope Changes check	✅ Passed	All changes are narrowly scoped to adding deprecated script paths to the cleanup function; no unrelated modifications or scope creep detected.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

• 📝 Generate docstrings (stacked PR)
• 📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch bugfix/t1542-cleanup-orphaned-scripts

📝 Coding Plan

• Generate coding plan for human review comments

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Tip

You can customize the high-level summary generated by CodeRabbit.

Configure the reviews.high_level_summary_instructions setting to provide custom instructions for generating the high-level summary.

[github-actions]

🔍 Code Quality Report

�[0;35m[MONITOR]�[0m Code Review Monitoring Report

�[0;34m[INFO]�[0m Latest Quality Status:
SonarCloud: 0 bugs, 0 vulnerabilities, 473 code smells

�[0;34m[INFO]�[0m Recent monitoring activity:
Tue Mar 17 16:05:45 UTC 2026: Code review monitoring started
Tue Mar 17 16:05:45 UTC 2026: SonarCloud - Bugs: 0, Vulnerabilities: 0, Code Smells: 473

📈 Current Quality Metrics

• BUGS: 0
• CODE SMELLS: 473
• VULNERABILITIES: 0

Generated on: Tue Mar 17 16:05:48 UTC 2026

---

Generated by AI DevOps Framework Code Review Monitoring

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[gemini-code-assist]

Code Review

This pull request correctly adds 14 orphaned scripts to the deprecated_paths array for cleanup. The change is straightforward and addresses the issue described. My feedback includes a suggestion to sort the newly added list of script paths alphabetically to improve readability and maintainability.

[gemini-code-assist]

For better readability and future maintenance, please sort this list of script paths alphabetically.

Suggested change

	"$agents_dir/scripts/pattern-tracker-helper.sh"
	"$agents_dir/scripts/quality-sweep-helper.sh"
	"$agents_dir/scripts/quality-loop-helper.sh"
	"$agents_dir/scripts/review-pulse-helper.sh"
	"$agents_dir/scripts/self-improve-helper.sh"
	"$agents_dir/scripts/coderabbit-pulse-helper.sh"
	"$agents_dir/scripts/coderabbit-task-creator-helper.sh"
	"$agents_dir/scripts/audit-task-creator-helper.sh"
	"$agents_dir/scripts/batch-cleanup-helper.sh"
	"$agents_dir/scripts/coordinator-helper.sh"
	"$agents_dir/scripts/finding-to-task-helper.sh"
	"$agents_dir/scripts/objective-runner-helper.sh"
	"$agents_dir/scripts/ralph-loop-helper.sh"
	"$agents_dir/scripts/stale-pr-helper.sh"
	"$agents_dir/scripts/audit-task-creator-helper.sh"
	"$agents_dir/scripts/batch-cleanup-helper.sh"
	"$agents_dir/scripts/coderabbit-pulse-helper.sh"
	"$agents_dir/scripts/coderabbit-task-creator-helper.sh"
	"$agents_dir/scripts/coordinator-helper.sh"
	"$agents_dir/scripts/finding-to-task-helper.sh"
	"$agents_dir/scripts/objective-runner-helper.sh"
	"$agents_dir/scripts/pattern-tracker-helper.sh"
	"$agents_dir/scripts/quality-loop-helper.sh"
	"$agents_dir/scripts/quality-sweep-helper.sh"
	"$agents_dir/scripts/ralph-loop-helper.sh"
	"$agents_dir/scripts/review-pulse-helper.sh"
	"$agents_dir/scripts/self-improve-helper.sh"
	"$agents_dir/scripts/stale-pr-helper.sh"