docs: add asc-cli dependency check and update web apps section#5690
docs: add asc-cli dependency check and update web apps section#5690alex-solovyev merged 1 commit intomainfrom
Conversation
Add install-on-demand instruction so agents know to install asc-cli from the correct Homebrew tap before first use. Remove obsolete local hosting workaround (sparse clone + symlinks) since v0.1.57 hosts web apps at asccli.app with 302 redirects from the local server.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly improves the clarity and accuracy of the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
WalkthroughUpdated App Store Connect tools documentation to redirect web apps to hosted pages on Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🔍 Code Quality Report�[0;35m[MONITOR]�[0m Code Review Monitoring Report �[0;34m[INFO]�[0m Latest Quality Status: �[0;34m[INFO]�[0m Recent monitoring activity: 📈 Current Quality Metrics
Generated on: Wed Mar 25 02:07:10 UTC 2026 Generated by AI DevOps Framework Code Review Monitoring |
|
🤖 Augment PR SummarySummary: Updates the App Store Connect (asc) subagent doc to match asc-cli’s hosted web apps and reduce first-run setup confusion.
🤖 Was this summary useful? React with 👍 or 👎 |
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
|
|
||
| **Requirements**: macOS 13+, App Store Connect API key | ||
|
|
||
| **Dependency check**: Before running any `asc` command, verify it is installed: `command -v asc >/dev/null || brew install tddworks/tap/asccli`. This is a Homebrew tap — `brew install asc` installs a different, unrelated package. |
There was a problem hiding this comment.
command -v asc only checks that some asc binary exists; if the unrelated asc formula is already installed, this check will pass and the doc’s warning won’t prevent the confusion. Consider validating that the installed asc is the asc-cli one (e.g., via a version/help signature) before skipping the tap install.
Severity: medium
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
| | **Command Center** | `asc web-server` | Interactive ASC dashboard — apps, builds, TestFlight, screenshots, subscriptions, reviews | | ||
| | **Console** | `asc web-server` | CLI reference + embedded terminal, Cmd+K search | | ||
| | **Screenshot Studio** | Static (separate) | Visual App Store screenshot builder with device bezels, text layers, gradient backgrounds | | ||
| Since v0.1.57, the web apps are hosted at asccli.app. The `asc web-server` command starts a local API bridge (`/api/run`) and redirects `/command-center/`, `/console/`, and `/` to the hosted versions (302). |
There was a problem hiding this comment.
This sentence lists redirects for /command-center/, /console/, and /, but the doc also highlights Screenshot Studio at /editor; it’s a bit unclear whether /editor is also redirected/hosted by asc web-server. Consider clarifying which routes are redirected vs which are purely hosted on asccli.app.
Severity: low
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
| ### Local API bridge | ||
|
|
||
| The Homebrew bottle installs the `asc` binary but `asc web-server` extracts only `server.js` to a temp directory — the web app static files (HTML/CSS/JS) are not included. You must clone them separately: | ||
| Run `asc web-server` to start the local API bridge. The web apps at asccli.app connect to it for CLI command execution. Default ports: 8420 (HTTP), 8421 (HTTPS). |
There was a problem hiding this comment.
“The web apps … connect to it for CLI command execution” may not apply to Screenshot Studio if it’s fully static (as implied by its purpose). Consider specifying which of the three apps actually require the local /api/run bridge so users don’t assume the editor depends on it.
Severity: low
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the app-store-connect.md documentation. It clarifies that asc web applications are now hosted online, with asc web-server acting as a local API bridge, and removes previous complex local hosting setup instructions. Additionally, it adds a dependency check for the asc CLI and updates markdown link formatting. The review feedback suggests an improvement to the newly added dependency check, recommending a preliminary check for Homebrew itself to enhance robustness for users who may not have it installed.
|
|
||
| **Requirements**: macOS 13+, App Store Connect API key | ||
|
|
||
| **Dependency check**: Before running any `asc` command, verify it is installed: `command -v asc >/dev/null || brew install tddworks/tap/asccli`. This is a Homebrew tap — `brew install asc` installs a different, unrelated package. |
There was a problem hiding this comment.
The dependency check instruction is a valuable addition. To make it more robust for users who might not have Homebrew installed, consider adding a preliminary check for brew itself before attempting to install asccli.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.agents/tools/mobile/app-store-connect.md (1)
279-279:⚠️ Potential issue | 🟡 MinorRelated link looks stale against the new hosted model.
services/hosting/local-hosting.md("localdev for asc-web hosting") conflicts with the updated guidance that web apps are hosted onasccli.app. Please update/remove this reference to avoid reintroducing deprecated setup paths.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.agents/tools/mobile/app-store-connect.md at line 279, The reference to "services/hosting/local-hosting.md" (described as "localdev for asc-web hosting") is outdated; update the mention in .agents/tools/mobile/app-store-connect.md to reflect the new hosted model by removing or replacing that link and text with the current guidance pointing to asccli.app (or the canonical hosting docs for asccli.app), and ensure any wording about "asc-web hosting" is changed to indicate web apps are hosted on asccli.app to avoid promoting the deprecated localdev setup.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In @.agents/tools/mobile/app-store-connect.md:
- Line 279: The reference to "services/hosting/local-hosting.md" (described as
"localdev for asc-web hosting") is outdated; update the mention in
.agents/tools/mobile/app-store-connect.md to reflect the new hosted model by
removing or replacing that link and text with the current guidance pointing to
asccli.app (or the canonical hosting docs for asccli.app), and ensure any
wording about "asc-web hosting" is changed to indicate web apps are hosted on
asccli.app to avoid promoting the deprecated localdev setup.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: b6135e4a-c62d-4bae-a079-127eefb51603
📒 Files selected for processing (1)
.agents/tools/mobile/app-store-connect.md
2 participants
Summary
ascfrom the correct Homebrew tap (tddworks/tap/asccli) before first use — prevents confusion with the unrelatedascformulaCloses #8 follow-up from tddworks/asc-cli#8.
Summary by CodeRabbit