fix: pass --non-interactive to setup.sh in supervisor and full-loop deploy phases#757
fix: pass --non-interactive to setup.sh in supervisor and full-loop deploy phases#757alex-solovyev wants to merge 1 commit intomainfrom
Conversation
…eploy phases supervisor-helper.sh run_deploy_for_task() and full-loop-helper.sh run_deploy_phase() both called setup.sh without --non-interactive, causing interactive prompts (e.g. Worktrunk shell integration) to hang or fail in headless/automated contexts. Fixes: t193
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
WalkthroughTwo helper scripts now invoke Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related issues
Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Closing: t193 was already fixed in PR #749 (merged to main). This PR is a duplicate. |
Summary
supervisor-helper.shrun_deploy_for_task()callingsetup.shwithout--non-interactive, causing interactive prompts to hang in headless contextsfull-loop-helper.shrun_deploy_phase()with the same issueRoot Cause
When the supervisor runs
setup.shas a deploy step (pr-lifecycle deploying phase), it fails becausesetup.shhits interactive prompts (e.g., "Install Worktrunk shell integration?") that require stdin. The--non-interactiveflag already exists and correctly skips all optional installs, but neither the supervisor nor full-loop-helper were passing it.aidevops.sh(the CLI) already passes--non-interactivecorrectly at lines 556 and 585 — this fix brings the supervisor and full-loop into alignment.Changes
supervisor-helper.sh:5059--non-interactiveto timeout pathsupervisor-helper.sh:5066--non-interactiveto fallback pathfull-loop-helper.sh:650--non-interactiveto deploy phaseTesting
bash -nsyntax check: PASS (both files)./setup.shinvocations now include--non-interactiveaidevops.shalready uses this pattern (consistency confirmed)Fixes: t193 ref:GH#720
Summary by CodeRabbit