Skip to content

fix: pass --non-interactive to setup.sh in supervisor and full-loop deploy phases#757

Closed
alex-solovyev wants to merge 1 commit intomainfrom
bugfix/t193-setup-non-interactive-deploy
Closed

fix: pass --non-interactive to setup.sh in supervisor and full-loop deploy phases#757
alex-solovyev wants to merge 1 commit intomainfrom
bugfix/t193-setup-non-interactive-deploy

Conversation

@alex-solovyev
Copy link
Copy Markdown
Collaborator

@alex-solovyev alex-solovyev commented Feb 9, 2026

Summary

  • Fix supervisor-helper.sh run_deploy_for_task() calling setup.sh without --non-interactive, causing interactive prompts to hang in headless contexts
  • Fix full-loop-helper.sh run_deploy_phase() with the same issue
  • Both timeout and fallback code paths in supervisor now pass the flag

Root Cause

When the supervisor runs setup.sh as a deploy step (pr-lifecycle deploying phase), it fails because setup.sh hits interactive prompts (e.g., "Install Worktrunk shell integration?") that require stdin. The --non-interactive flag already exists and correctly skips all optional installs, but neither the supervisor nor full-loop-helper were passing it.

aidevops.sh (the CLI) already passes --non-interactive correctly at lines 556 and 585 — this fix brings the supervisor and full-loop into alignment.

Changes

File Change
supervisor-helper.sh:5059 Add --non-interactive to timeout path
supervisor-helper.sh:5066 Add --non-interactive to fallback path
full-loop-helper.sh:650 Add --non-interactive to deploy phase

Testing

  • bash -n syntax check: PASS (both files)
  • Verified all 3 ./setup.sh invocations now include --non-interactive
  • Verified aidevops.sh already uses this pattern (consistency confirmed)

Fixes: t193 ref:GH#720

Summary by CodeRabbit

  • Chores
    • Updated deployment automation to run setup operations in non-interactive mode.

…eploy phases

supervisor-helper.sh run_deploy_for_task() and full-loop-helper.sh
run_deploy_phase() both called setup.sh without --non-interactive,
causing interactive prompts (e.g. Worktrunk shell integration) to
hang or fail in headless/automated contexts.

Fixes: t193
@gemini-code-assist
Copy link
Copy Markdown

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Feb 9, 2026

Walkthrough

Two helper scripts now invoke setup.sh with a --non-interactive flag instead of standard invocation. The change applies to both the timeout-enabled and fallback code paths in supervisor-helper.sh, plus the deploy phase in full-loop-helper.sh.

Changes

Cohort / File(s) Summary
Non-interactive Setup Flag
.agents/scripts/full-loop-helper.sh, .agents/scripts/supervisor-helper.sh
Added --non-interactive flag to all setup.sh invocations to enforce non-interactive execution mode, affecting both timeout-wrapped and fallback deploy paths.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related issues

Possibly related PRs

Suggested reviewers

  • marcusquinn

Poem

🚀 Scripts now speak in silence, no prompts to delay,
Setup runs unattended through supervisor's way,
With flags set to non-interactive, deployment's on track,
No waiting for input—just forward, no looking back! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately and specifically describes the main change: adding --non-interactive flag to setup.sh calls in supervisor and full-loop deploy phases.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch bugfix/t193-setup-non-interactive-deploy

No actionable comments were generated in the recent review. 🎉


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@alex-solovyev
Copy link
Copy Markdown
Collaborator Author

Closing: t193 was already fixed in PR #749 (merged to main). This PR is a duplicate.

@alex-solovyev alex-solovyev deleted the bugfix/t193-setup-non-interactive-deploy branch February 9, 2026 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant