Skip to content
This repository was archived by the owner on Sep 11, 2023. It is now read-only.

Conversation

@marscher
Copy link
Member

  • Ensures only save modules/packages can be restored.
  • handling of renamed classes, modules, packages handled.
  • store pyemma version in the h5 file during save.
  • restored objects have the private field '_restored_from_pyemma_version'
  • 20 times faster than jsonpickle

@markovmodel markovmodel deleted a comment from codecov bot Dec 12, 2017
@codecov
Copy link

codecov bot commented Dec 14, 2017

Codecov Report

Merging #1200 into models_estimators_serializable will decrease coverage by <.01%.
The diff coverage is 96.58%.

Impacted file tree graph

@@                        Coverage Diff                        @@
##           models_estimators_serializable   #1200      +/-   ##
=================================================================
- Coverage                            91.3%   91.3%   -0.01%     
=================================================================
  Files                                 212     214       +2     
  Lines                               22342   22380      +38     
=================================================================
+ Hits                                20400   20434      +34     
- Misses                               1942    1946       +4
Impacted Files Coverage Δ
pyemma/msm/tests/test_reactive_flux.py 99.12% <100%> (+0.13%) ⬆️
pyemma/_base/serialization/tests/test_topology.py 100% <100%> (ø)
pyemma/_base/serialization/util.py 81.57% <100%> (-10.53%) ⬇️
pyemma/coordinates/tests/test_serialization.py 98.15% <100%> (ø) ⬆️
...ma/_base/serialization/tests/test_serialization.py 94.15% <100%> (+0.27%) ⬆️
pyemma/_base/serialization/mdtraj_helpers.py 88.63% <88.63%> (ø)
pyemma/msm/models/reactive_flux.py 93.89% <96%> (-0.18%) ⬇️
pyemma/_base/serialization/serialization.py 88.76% <98.14%> (+0.48%) ⬆️
pyemma/_base/serialization/pickle_extensions.py 98.3% <98.3%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11f4aac...953f9d4. Read the comment docs.

@marscher marscher merged commit b2ccbeb into markovmodel:models_estimators_serializable Dec 15, 2017
@marscher marscher deleted the switch_to_pickle branch December 15, 2017 09:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant