Skip to content
This repository was archived by the owner on Sep 11, 2023. It is now read-only.

Conversation

@brookehus
Copy link
Contributor

I decided it was easier to add a parameter to init but let me know if you prefer something different. What kind of tests do you want for this?

  • Make sure to include one or more tests for your change
  • Add yourself to AUTHORS
  • Add a new entry to the doc/source/CHANGELOG (choose any open position to avoid merge conflicts with other PRs).
    Decide whether your change is a fix or a new feature.

@brookehus
Copy link
Contributor Author

cc @thempel

@codecov
Copy link

codecov bot commented Jan 30, 2019

Codecov Report

Merging #1388 into devel will decrease coverage by 0.01%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##            devel    #1388      +/-   ##
==========================================
- Coverage   91.55%   91.54%   -0.02%     
==========================================
  Files         225      225              
  Lines       25450    25454       +4     
==========================================
  Hits        23302    23302              
- Misses       2148     2152       +4
Impacted Files Coverage Δ
pyemma/datasets/double_well_thermo.py 94.25% <88.88%> (-0.93%) ⬇️
pyemma/util/statistics.py 59.4% <0%> (-1%) ⬇️
pyemma/coordinates/data/util/traj_info_backends.py 90.61% <0%> (-0.94%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9072714...373315a. Read the comment docs.

@marscher
Copy link
Member

Should I wait for a test or not? This seems like a minor change, which is not really exposed to user api.

@brookehus
Copy link
Contributor Author

If there should be a test let me know what I should test. I don't mind either way.

@marscher marscher merged commit c44f071 into markovmodel:devel Jan 31, 2019
@marscher
Copy link
Member

LGTM

@brookehus brookehus deleted the dw-random branch January 31, 2019 08:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants