Improve performance and country picker customization#876
Improve performance and country picker customization#876bguidolim merged 16 commits intomarmelroy:masterfrom
Conversation
Improved cross region parsing when no country code extracted from str…
…melroy-master # Conflicts: # PhoneNumberKit.podspec
# Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
|
Hey @Splash04 Thanks for your contribution. To be honest, I'm not giving much attention to the UI part of PNK anymore, I was even thinking to remove it from the library and keep only the parsing and formatting logic. However, if it's useful for you, it can be useful for other, so I'm merging this. Thanks again. |
|
I needed more flexibly with UI to make it works without issues in SwiftUI view in my project. So I spend some time learning how it implemented and how it can be updated. In general, I prefer a bite different structure of UI code. But I was trying to make it similar to your implementation to not create a lot of migration issue for lib users. If you don't have time to update UI part, I can take a look at it one more time and make some additional changes according to issue requests. This might be useful while I remember how everything works :) |
Performance improvements:
Customization:
Add CustomCountryPickerCells example project to test cell customization.
And other small changes.
Tested only on iOS 15+.
P.S.: You are free to decline it if fill that this changes is not needed in the main repo.