feat: add match and cases (#346)
#351
Merged
+318
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thank you for your interest 🙏 @2chanhaeng Could you please just add the |
Contributor
Author
|
@ppeeou Fixed! |
ppeeou
reviewed
Nov 11, 2025
Member
ppeeou
left a comment
ppeeou
left a comment
There was a problem hiding this comment.
@2chanhaeng Sorry for the late reply🙏
I think I'm missing the general test case writing part. Just adding that would be enough.
Contributor
Author
|
@ppeeou Added! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #346
I also implement
cases, more flexible than match.If you don't think
casesis needed, I'll reqeust again withoutcases.