feat!: add support for namespaced functions#343
Merged
martinohmann merged 8 commits intomainfrom May 16, 2024
Merged
Conversation
Not really needed for this feature yet. Can be added later if desired.
Not strictly necessary for this feature
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #335
This adds support for namespaced HCL function calls. The PR includes updates to the HCL parser (
hcl-edit), formatter (hcl-rs), evaluation context (hcl-rs), encoder (hcl-edit) and visitors (hcl-edit).BREAKING CHANGE: The
identfield ofhcl_edit::expr::FuncCallwas renamed toname. Its type changed fromDecorated<Ident>toFuncName. The type ofhcl::expr::FuncCall'snamefield changed fromIdentifiertoFuncName. Various other places in the codebase that previously used bare identifiers as type now useFuncNameto accommodate the change.