Fix IAsyncEnumerable<object> CreateStream for Value Types#37
Merged
martinothamar merged 5 commits intomartinothamar:mainfrom May 30, 2022
Merged
Fix IAsyncEnumerable<object> CreateStream for Value Types#37martinothamar merged 5 commits intomartinothamar:mainfrom
martinothamar merged 5 commits intomartinothamar:mainfrom
Conversation
Tornhoof
changed the title
Contributor
Author
|
The test failure is not related to my changes, apparently VS 17.2 Roslyn broke the test 'Mediator.SourceGenerator.Tests.CleanArchitectureSampleTests.Test_Source_Gen'. The failure happens on main too. It worked with an older 6.0 sdk (from VS 17.1.6) |
Owner
|
Thanks for finding and fixing 👍 I see the test failure is unrelated, will merge and look into the buggy test |
martinothamar
approved these changes
May 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a special case for IAsyncEnumerable CreateStream if the response type is a struct.
It then calls a wrapper method for the async object enumeration.
I chose the simple wrapper method approach, instead of writing some custom type as the automatically generated state machines for async enumerables contain quite a lot of optimization w.r.t IValueTaskSource etc. according to https://docs.microsoft.com/en-us/archive/msdn-magazine/2019/november/csharp-iterating-with-async-enumerables-in-csharp-8
Closes #36