Fix http/timeout while waiting for command output#148
Merged
masterzen merged 3 commits intomasterzen:masterfrom Dec 22, 2023
Merged
Fix http/timeout while waiting for command output#148masterzen merged 3 commits intomasterzen:masterfrom
masterzen merged 3 commits intomasterzen:masterfrom
Conversation
Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
masterzen
reviewed
Dec 21, 2023
todo: need to remove the interface Co-authored-by: Brice Figureau <brice+github@figureau.eu>
Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #147
In addition to the existing SOAP OperationTimeout, this PR makes the output retriever check if the error returned from the HTTP request is a http/timeout, which needs to be handled the same way.