Skip to content

Windows compatability for examples#71

Merged
ferdymercury merged 7 commits intomateidavid:masterfrom
LuNoX:windows-compatability-for-examples
Oct 17, 2025
Merged

Windows compatability for examples#71
ferdymercury merged 7 commits intomateidavid:masterfrom
LuNoX:windows-compatability-for-examples

Conversation

@LuNoX
Copy link
Contributor

@LuNoX LuNoX commented Oct 17, 2025

Because of line ending issues the test configuration examples would fail every time. This PR solves the issue.

New output from a windows machine:

g++ -std=c++11 -O0 -g3 -ggdb -fno-eliminate-unused-debug-types -Wall -Wextra -pe
dantic -I../src -o ztxtpipe ztxtpipe.cpp -lz
g++ -std=c++11 -O0 -g3 -ggdb -fno-eliminate-unused-debug-types -Wall -Wextra -pe
dantic -I../src -o zpipe zpipe.cpp -lz
g++ -std=c++11 -O0 -g3 -ggdb -fno-eliminate-unused-debug-types -Wall -Wextra -pe
dantic -I../src -o zc zc.cpp -lz
diff -q ztxtpipe.cpp <(./ztxtpipe <ztxtpipe.cpp)
diff -q ztxtpipe.cpp <(gzip <ztxtpipe.cpp | ./ztxtpipe)
diff -q ztxtpipe.cpp <(gzip -9 <ztxtpipe.cpp | ./ztxtpipe)
diff -q <(cat ztxtpipe.cpp ztxtpipe.cpp) <(cat ztxtpipe.cpp ztxtpipe.cpp | gzip
| ./ztxtpipe)
diff -q <(cat ztxtpipe.cpp ztxtpipe.cpp) <({ gzip <ztxtpipe.cpp; gzip <ztxtpipe.
cpp; } | ./ztxtpipe)
diff -q zpipe.cpp <(./zpipe <zpipe.cpp)
diff -q zpipe.cpp <(gzip <zpipe.cpp | ./zpipe)
diff -q zpipe.cpp <(gzip -9 <zpipe.cpp | ./zpipe)
diff -q <(cat zpipe.cpp zpipe.cpp) <(cat zpipe.cpp zpipe.cpp | gzip | ./zpipe)
diff -q <(cat zpipe.cpp zpipe.cpp) <({ gzip <zpipe.cpp; gzip <zpipe.cpp; } | ./z
pipe)
diff -q <(<zpipe.cpp | gzip) <(<zpipe.cpp | gzip | gzip | ./zpipe)
diff -q zc.cpp <(./zc <zc.cpp)
diff -q zc.cpp <(./zc - <zc.cpp)
diff -q zc.cpp <(./zc - - <zc.cpp)
diff -q zc.cpp <(./zc zc.cpp)
diff -q zc.cpp <(<zc.cpp gzip | ./zc)
diff -q zc.cpp <(<zc.cpp gzip | ./zc -)
diff -q zc.cpp <(<zc.cpp gzip | ./zc - -)
diff -q zc.cpp <(<zc.cpp ./zc -c | zcat)
diff -q zc.cpp <(<zc.cpp ./zc -c - | zcat)
diff -q zc.cpp <(<zc.cpp ./zc -c - - | zcat)
diff -q zc.cpp <(./zc -c zc.cpp | zcat)
diff -q <(cat zc.cpp zc.cpp) <(./zc -c zc.cpp - <zc.cpp | zcat)
diff -q <(cat zc.cpp zc.cpp) <(./zc -c - zc.cpp <zc.cpp | zcat)
diff -q <(cat zc.cpp zc.cpp) <(./zc -c zc.cpp zc.cpp | zcat)
diff -q <(cat zc.cpp zc.cpp) <({ ./zc -c zc.cpp; ./zc -c zc.cpp; } | zcat)
diff -q <(cat zc.cpp zc.cpp) <({ gzip <zc.cpp; ./zc -c zc.cpp; } | zcat)
diff -q <(cat zc.cpp zc.cpp) <({ ./zc -c zc.cpp; gzip <zc.cpp; } | zcat)
all passed 

@LuNoX LuNoX force-pushed the windows-compatability-for-examples branch from 917f2f8 to aec7d19 Compare October 17, 2025 04:13
@LuNoX LuNoX marked this pull request as ready for review October 17, 2025 04:25
@LuNoX
Copy link
Contributor Author

LuNoX commented Oct 17, 2025

It appears this behavior was previously fixed in ERGO-Code/HiGHS#793 but the fix was never merged here only in the HiGHS repo. It also makes clear that always opening in binary will cause problems on macOS. As such I will amend to only open in binary on windows systems

@ferdymercury ferdymercury merged commit 7c04198 into mateidavid:master Oct 17, 2025
LuNoX added a commit to LuNoX/zstr that referenced this pull request Oct 17, 2025
Windows compatibility for examples (mateidavid#71)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants