Open
Conversation
|
Any news regarding this change? My team is looking forward to seeing it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an es module (
he.esm.js). This is currently handcrafted by basically removing the UMD wrapper and adding the exports at the bottom of the file. This file is then references frompackage.jsonusing themodulefield. This is in my opinion a non-breaking change.I hope this can be published soon as it would allow
heto be used by packages that are esm based and and bundlers that have difficulties to detect the exported names.I'd like to have this automated but i could not get the grunt build to run:
Any hint about how to solve this and i would adjust the PR.
Related #76