Merged
Conversation
JLHwung
commented
Sep 18, 2023
| "unicode-match-property-value-ecmascript": "^2.1.0" | ||
| }, | ||
| "devDependencies": { | ||
| "codecov": "^3.8.3", |
Collaborator
Author
There was a problem hiding this comment.
It seems that we are not using codecov anyway. If we want to use it we can add a GH action codecov-action later.
Collaborator
There was a problem hiding this comment.
It would be great to add it 👍
JLHwung
force-pushed
the
update-test-infra
branch
from
cd7684b to
b3e88ec
Compare
nicolo-ribaudo
approved these changes
Sep 19, 2023
| - name: Install dependencies | ||
| run: npm install | ||
| - name: Downgrade mocha | ||
| - name: Install mocha 6 |
Collaborator
There was a problem hiding this comment.
We are keeping Node.js 6 compatibility because Babel needs it, but @mathiasbynens how do you feel about dropping it once we release Babel 8 (which will drop support for all the currently not maintained Node.js versions)?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrated to the builtin node test runner so that we have less dev deps to care about.
This PR contains commits from #81 which fixed the CI error. Please review the last commit only.