Fix UIA password flow not advertised for LDAP users#378
Open
yefimg wants to merge 1 commit intomatrix-construct:mainfrom
Open
Fix UIA password flow not advertised for LDAP users#378yefimg wants to merge 1 commit intomatrix-construct:mainfrom
yefimg wants to merge 1 commit intomatrix-construct:mainfrom
Conversation
LDAP users are registered with a sentinel password ("*"), causing
has_password() to return false. This meant no authentication flow was
advertised in UiaaInfo for these users, breaking operations that require
User-Interactive Authentication (e.g. encryption reset / cross-signing
key upload) with "No appropriate authentication flow found".
Advertise the password flow when LDAP is enabled, since the UIAA service
already supports verifying credentials against LDAP.
yefimg
force-pushed
the
fix/uiaa-ldap-password-flow
branch
from
a0845cb to
c524d96
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix "No appropriate authentication flow found" error for LDAP users trying to reset the password.
Advertise the password flow when LDAP is enabled.