Skip to content

feat(sdk): Refresh well-known cache in the background#6480

Merged
andybalaam merged 4 commits intomatrix-org:mainfrom
zecakeh:well-known-cache-task
Apr 22, 2026
Merged

feat(sdk): Refresh well-known cache in the background#6480
andybalaam merged 4 commits intomatrix-org:mainfrom
zecakeh:well-known-cache-task

Conversation

@zecakeh
Copy link
Copy Markdown
Collaborator

@zecakeh zecakeh commented Apr 22, 2026

Follow up to #6463, this time for the well-known cache.

The 2 last commits are for cleaning up the code a bit.

  • I've documented the public API Changes in the appropriate CHANGELOG.md files.
  • This PR was made with the help of AI.

zecakeh added 3 commits April 22, 2026 09:40
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
This API is no longer in use so we can remove it. We also rename
`into_data_unchecked()` to `into_data()`.

Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
@zecakeh zecakeh requested a review from a team as a code owner April 22, 2026 07:54
@zecakeh zecakeh requested review from andybalaam and removed request for a team April 22, 2026 07:54
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 22, 2026

Codecov Report

❌ Patch coverage is 86.15385% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.94%. Comparing base (fd6cb66) to head (7a1ff58).
⚠️ Report is 7 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/matrix-sdk/src/client/mod.rs 85.93% 7 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6480      +/-   ##
==========================================
+ Coverage   89.93%   89.94%   +0.01%     
==========================================
  Files         381      381              
  Lines      105530   105554      +24     
  Branches   105530   105554      +24     
==========================================
+ Hits        94907    94941      +34     
+ Misses       6994     6989       -5     
+ Partials     3629     3624       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 22, 2026

Merging this PR will improve performance by 48.08%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 1 improved benchmark
✅ 49 untouched benchmarks

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation Restore session [memory store] 166.9 ms 112.7 ms +48.08%

Comparing zecakeh:well-known-cache-task (7a1ff58) with main (38f34e6)

Open in CodSpeed

Copy link
Copy Markdown
Member

@andybalaam andybalaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

Comment thread crates/matrix-sdk/src/client/mod.rs Outdated
Comment thread crates/matrix-sdk/src/client/mod.rs
Signed-off-by: Andy Balaam <mail@artificialworlds.net>
@andybalaam andybalaam enabled auto-merge (rebase) April 22, 2026 09:37
@andybalaam andybalaam merged commit c7d44dd into matrix-org:main Apr 22, 2026
53 checks passed
@zecakeh zecakeh deleted the well-known-cache-task branch April 22, 2026 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants