Use Requests for NetboxAPI#57
Merged
matt852 merged 4 commits intomatt852:developmentfrom Feb 10, 2018
layertwo:feature/netbox-requests
Merged
Use Requests for NetboxAPI#57matt852 merged 4 commits intomatt852:developmentfrom layertwo:feature/netbox-requests
matt852 merged 4 commits intomatt852:developmentfrom
layertwo:feature/netbox-requests
Conversation
added 4 commits
February 9, 2018 21:13
….py, and reference the object in views.py and db_modifyDatabase.py.
matt852
added a commit
that referenced
this pull request
Feb 10, 2018
* add travis integration to slack (#53) * Add flaskenv to gitignore * Added tracking .txt file for which functions have a test written already * Add tests. Begin Python3 conversion. * Fix broken NXOS unit test * Add TravisCI badge to Readme. Updated docs * Add coveralls support * Update docs with coveralls badge * Fix travis file type * Fix #54 bug when adding new device with local credentials * Fix #55 and #56 issues with underscores in iShell and interface edit Modal * Cleanup code for issue #47. Still WIP * Fix #46 issue * Add description display for NX-OS interfaces * Use Requests for NetboxAPI (#57) * Refactor all Netbox API calls to use Python requests. * Convert NetboxAPI into its own object, define that object in __init__.py, and reference the object in views.py and db_modifyDatabase.py. * Workaround for not having a NetboxServer defined (unittesting) * Update to version 1.3.4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's the basic overview of what I did in this PR:
Future work here (different PR) is building a handler between the views and data sources.
This will be some future object that knows if it needs to pull from Netbox or add/modify/delete from the local database. This would clear up the problem of checking which data source to use in the view and allow for some building modularity if the need to use some other IPAM system comes up. Plus, it simplifies the code!