Minor core refactor. Fix some tests.#61
Open
wallclimber21 wants to merge 5 commits into
Open
Conversation
- Fix specific files test: it didn't actually load the files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm planning to add some minor additional functionality, but before doing that (and submitting it), I've refactored some of the Unzip which has seen quite a bit of copy-and-paste.
I also added an Unzip test for hierarchical zip files.
And I fixed the testForCrashWithSpecificFiles test case, which wasn't actually doing anything because it wasn't reading the files.