Merged
Conversation
gabrieljackson
added
2: Dev Review
mm-cloud-bot
added
release-note
This change adds k8s custom volume label and cleanup functionality so that secret resources are removed when they are no longer required by an installation's specification.
gabrieljackson
force-pushed
the
cleanup-custom-volumes
branch
from
86db18c to
3ced9a0
Compare
stafot
approved these changes
Jan 6, 2025
nickmisasi
approved these changes
Jan 6, 2025
gabrieljackson
added
4: Reviews Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds k8s custom volume label and cleanup functionality so that secret resources are removed when they are no longer required by an installation's specification.
Fixes https://mattermost.atlassian.net/browse/CLD-8739