Conversation
mm-cloud-bot
added
the
release-note
stafot
added
2: Dev Review
| return map[string]string{ | ||
| "installation-id": installation.ID, | ||
| "cluster-installation-id": clusterInstallation.ID, | ||
| "dns": strings.TrimSuffix(clusterInstallation.ClusterID, "-public"), |
There was a problem hiding this comment.
ClusterIDs should only ever be our standard 26 char IDs. Is there a reason we expect this suffix to exist?
There was a problem hiding this comment.
@gabrieljackson Added this suffix mostly for sanity reasons to know that these ingreses will be handled by our public external DNS we will have a different one for the private DNSes we are using but for this we don't need any provisioner code changes as it affects only argo utilities
…ling Signed-off-by: Stavros Foteinopoulos <stafot@gmail.com>
| if cluster != nil && cluster.Name != "" { | ||
| labels["dns"] = cluster.Name + "-public" | ||
| } |
There was a problem hiding this comment.
The cluster name is a value we can change at any time and was originally meant as a way to give a cluster a short description that is helpful to us. I just want to check that this is indeed the value we will want to use for external DNS as we will need to be careful to not change it once set.
There was a problem hiding this comment.
@gabrieljackson the problem that leads me to adopt this solution is that argoCD doesn't have the provisioner cluster id but has provisioner cluster name as info that can use in labelling @andrleite can provide more context if needed to why I was forced to this solution which was not preferred by me too
stafot
added
4: Reviews Complete
4 participants
Summary
CLD-9019: Add labels to cluster installation for external-dns ingress handling
Ticket Link
https://mattermost.atlassian.net/browse/CLD-9019
Release Note