Fix implicit integer conversion warnings with clang-21#33
Merged
mattgodbolt merged 1 commit intomainfrom Nov 3, 2025
Merged
Conversation
Clang-21 is stricter about implicit integer conversions than clang-20. The bitwise NOT operator (~) on uint8_t/uint16_t promotes to int, requiring explicit casts back to the smaller types. Fixed in 4 locations: - Flags::operator~(): Added static_cast<std::uint8_t> - Alu::sub8(): Added static_cast<std::uint8_t> for ~rhs - Alu::sub16(): Added static_cast<std::uint16_t> for ~rhs - Alu::sbc16(): Added static_cast<std::uint16_t> for ~rhs All tests pass with clang-21.1.0. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Owner
Author
|
Despite the failing build (cc @hanickadot ) - I am going to merge this as it fixes some clang issues on Linux too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Details
Clang-21 is stricter about implicit integer conversions than clang-20. The bitwise NOT operator (
~) onuint8_t/uint16_tpromotes tointdue to C++ integer promotion rules, requiring explicit casts back to the smaller types.Changes
Fixed in 4 locations:
Flags::operator~(): Addedstatic_cast<std::uint8_t>Alu::sub8(): Addedstatic_cast<std::uint8_t>for~rhsAlu::sub16(): Addedstatic_cast<std::uint16_t>for~rhsAlu::sbc16(): Addedstatic_cast<std::uint16_t>for~rhsTest plan
🤖 Generated with Claude Code