Skip to content

Conversation

@dennisameling
Copy link
Member

@dennisameling dennisameling commented Jun 2, 2021

We've had some issues with PHP sessions in the past. Check if using Redis also works, hopefully it will speed up the tests as well!

More context in mautic/mautic#2546 (comment) and https://ma.ttias.be/php-session-locking-prevent-sessions-blocking-in-requests/

@cla-bot cla-bot bot added the cla-signed label Jun 2, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #252 (9cbc633) into main (0714245) will not change coverage.
The diff coverage is n/a.

❗ Current head 9cbc633 differs from pull request most recent head ff64266. Consider uploading reports for the commit ff64266 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##               main     #252   +/-   ##
=========================================
  Coverage     51.45%   51.45%           
  Complexity      406      406           
=========================================
  Files            30       30           
  Lines          1028     1028           
=========================================
  Hits            529      529           
  Misses          499      499           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0714245...ff64266. Read the comment docs.

@dennisameling dennisameling marked this pull request as ready for review June 2, 2021 10:38
@dennisameling
Copy link
Member Author

dennisameling commented Jun 2, 2021

Tests are a little faster at 8m25, and we're not dependent on file session storage anymore!

@dennisameling dennisameling changed the title [WIP] Try using Redis for session storage Use Redis for session storage in CI Jun 2, 2021
@dennisameling dennisameling added the chore Tasks that relate to maintaining this Github repository label Jun 2, 2021
Copy link
Member

@RCheesley RCheesley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome - thanks for looking into this!

@dennisameling dennisameling merged commit 5cda363 into main Jun 3, 2021
@dennisameling dennisameling deleted the use-redis-for-sessions branch June 3, 2021 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Tasks that relate to maintaining this Github repository cla-signed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants