Add PHPSTAN #325
Merged
Add PHPSTAN #325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks @matbcvo - I have just set the tests running! 🤞 |
Member
|
@all-contributors please add @matbcvo for code, tests |
Contributor
|
I've put up a pull request to add @matbcvo! 🎉 |
Contributor
Author
|
@RCheesley Could you please set tests run again? |
escopecz
approved these changes
Jul 18, 2024
Member
escopecz
left a comment
escopecz
left a comment
There was a problem hiding this comment.
These changes look great. Most of them are in tests and not a production code. The one change in the production code makes sense 👍 Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supersedes an earlier attempt to integrate PHPSTAN, which encountered conflicts. The conflicts have been resolved in this updated implementation.