RemoteID: Fix EU operator ID validation never running

[julianoes]

Description

Fix operator ID validation.

Type of Change

The QML onTextChanged handler was setting operatorIDFact.value before calling checkOperatorID(), so the C++ validation check comparing input against stored value was always equal, causing validation to be skipped.

Testing

• Tested locally
• Added/updated unit tests
• Tested with simulator (SITL)
• Tested with hardware

Platforms Tested

• Linux
• Windows
• macOS
• Android
• iOS

Flight Stacks Tested

• PX4
• ArduPilot

Screenshots

Checklist

• I have read the Contribution Guidelines
• I have read the Code of Conduct
• My code follows the project's coding standards
• I have added tests that prove my fix/feature works
• New and existing unit tests pass locally

Related Issues

Closes #11750.

---

By submitting this pull request, I confirm that my contribution is made under the terms of the project's dual license (Apache 2.0 and GPL v3).

[github-actions]

Pre-commit Checks Failed

Status	Count
Passed	13
Failed	45

Hook Results

check yaml...............................................................Passed
check json...............................................................Passed
pretty format json.......................................................Failed
check xml................................................................Passed
check for merge conflicts................................................Passed
check for added large files..............................................Passed
trim trailing whitespace.................................................Passed
fix end of files.........................................................Failed
mixed line ending........................................................Passed
TruffleHog...............................................................Passed
clang-format.............................................................Failed
clang-tidy...............................................................Failed
ruff (legacy alias)......................................................Failed
ruff format..............................................................Failed
pyright..................................................................Failed
shellcheck...............................................................Failed
cmake-format.............................................................Failed
cmake-lint...............................................................Failed
Lint GitHub Actions workflow files.......................................Failed
yamllint.................................................................Passed
markdownlint.............................................................Failed
vale.....................................................................Failed
typos....................................................................Failed
Lint QML files...........................................................Failed
Qt static analysis (clazy)...............................................Passed
Check for Q_ASSERT in production code....................................Passed
Check vehicle null safety................................................Failed

Files Modified by Hooks

 .github/workflows/pr-checks.yml | 1 -
 1 file changed, 1 deletion(-)

How to Fix

./tools/pre-commit.sh
git add -u && git commit --amend --no-edit

_{Run ID: 20562515381}

[github-actions]

Build Results

Platform Status

Platform	Status	Details
Linux	Passed	View
Windows	Passed	View
MacOS	Passed	View
Android	Passed	View

All builds passed.

Artifact Sizes

Artifact	Size
QGroundControl-mac.apk	410.65 MB
QGroundControl-windows.apk	409.56 MB
QGroundControl.apk	761.91 MB

No baseline available for comparison

_{Updated: 2025-12-29 02:25:17 UTC • Triggered by: Android}

[julianoes]

Not sure what the pre-commit hook is failing with. When I run it locally, it seems to pass:

pre-commit run                     
[WARNING] The 'rev' field of repo '.' appears to be a mutable reference (moving tag / branch).  Mutable references are never updated after first install and are not supported.  See https://pre-commit.com/#using-the-latest-version-for-a-repository for more details.  Hint: `pre-commit autoupdate` often fixes this.
check yaml...........................................(no files to check)Skipped
check json...........................................(no files to check)Skipped
pretty format json...................................(no files to check)Skipped
check xml............................................(no files to check)Skipped
check for merge conflicts................................................Passed
check for added large files..............................................Passed
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
mixed line ending........................................................Passed
TruffleHog...............................................................Passed
clang-format.........................................(no files to check)Skipped
clang-tidy...........................................(no files to check)Skipped
ruff (legacy alias)..................................(no files to check)Skipped
ruff format..........................................(no files to check)Skipped
pyright..............................................(no files to check)Skipped
shellcheck...........................................(no files to check)Skipped
cmake-format.........................................(no files to check)Skipped
cmake-lint...........................................(no files to check)Skipped
Lint GitHub Actions workflow files...................(no files to check)Skipped
yamllint.............................................(no files to check)Skipped
markdownlint.........................................(no files to check)Skipped
vale.................................................(no files to check)Skipped
typos....................................................................Passed
Lint QML files...........................................................Passed
Qt static analysis (clazy)...........................(no files to check)Skipped
Check for Q_ASSERT in production code................(no files to check)Skipped
Check vehicle null safety............................(no files to check)Skipped

[HTRamsey]

I'd just ignore the pre-commit thing for now. I'm still working on it

[julianoes]

@HTRamsey any objections to getting this in?