cmake: Fix preset version and ccache config compatibility #13824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to improve IDE compatibility by downgrading the CMake preset version from 6 to 5 for Qt Creator support and fixing ccache configuration issues when loaded directly by IDEs.
Key Changes:
- Downgrade CMake preset version from 6 to 5 in two preset files
- Comment out relative path settings in ccache.conf (cache_dir and base_dir) with improved explanatory comments
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| cmake/presets/common.json | Downgrade preset version from 6 to 5 for Qt Creator compatibility |
| CMakePresets.json.template | Downgrade preset version from 6 to 5 for Qt Creator compatibility |
| tools/ccache.conf | Comment out cache_dir and base_dir settings with improved explanatory comments noting CMake sets these via environment variables |
Comment out relative paths in ccache.conf (cache_dir and base_dir). CMake sets these via environment variables, but IDEs loading the config directly without CMake's overrides would get ccache errors.
- Downgrade preset version from 6 to 5 for Qt Creator compatibility - Add cmakeMinimumRequired to common.json - Simplify configure presets using hidden base configs and inheritance - Consolidate build presets with default jobs=0 (use all cores) - Standardize workflow presets across platforms - Remove redundant preset variations in favor of inheritance - Clean up debug/release preset naming conventions This reduces duplication and makes presets more maintainable.
HTRamsey
force-pushed
the
fix/ccache-qt-creator-compatibility
branch
from
399ab15 to
85115fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
cache_dir = .cache/ccache,base_dir = .) cause ccache errors when IDEs load the config directly without CMake's environment variable overridesSolution
CCACHE_DIRandCCACHE_BASEDIRenvironment variables which take precedenceTest plan