Release 4.1.0#371
Conversation
oschwald
commented
May 12, 2026
oschwald
commented
- Set release date
- Preparing for 4.1.0
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the project version to 4.1.0 and refreshes the copyright dates across the documentation and build files. Feedback suggests updating the Gradle documentation to use the modern implementation configuration instead of the deprecated compile keyword. Additionally, it is recommended to keep the japicmp.baselineVersion at the previous stable version (4.0.2) to ensure API compatibility checks remain effective during the release process.
| } | ||
| dependencies { | ||
| compile 'com.maxmind.db:maxmind-db:4.0.2' | ||
| compile 'com.maxmind.db:maxmind-db:4.1.0' |
There was a problem hiding this comment.
The compile configuration in Gradle has been deprecated for a long time and was removed in Gradle 7.0. It is recommended to use implementation instead for library dependencies in documentation examples to ensure they work with modern Gradle versions.
| compile 'com.maxmind.db:maxmind-db:4.1.0' | |
| implementation 'com.maxmind.db:maxmind-db:4.1.0' |
| <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | ||
| <!-- Baseline version for API compatibility checking. Update after each release. --> | ||
| <japicmp.baselineVersion>4.0.2</japicmp.baselineVersion> | ||
| <japicmp.baselineVersion>4.1.0</japicmp.baselineVersion> |
There was a problem hiding this comment.
Updating the japicmp.baselineVersion to the current version (4.1.0) during the release process effectively disables the API compatibility check for this release. The plugin will attempt to compare the current build against version 4.1.0, which likely hasn't been published yet (causing a build failure) or will result in a trivial comparison against itself. It is best practice to keep the baseline at the previous stable version (4.0.2) until the release is finalized, and only update it for the subsequent development cycle.
| <japicmp.baselineVersion>4.1.0</japicmp.baselineVersion> | |
| <japicmp.baselineVersion>4.0.2</japicmp.baselineVersion> |
2 participants
