This repository was archived by the owner on Jul 27, 2025. It is now read-only.
fix: use correct delimiter on credit card zero values#1280
Merged
zachgoll merged 1 commit intomaybe-finance:mainfrom Oct 10, 2024
Merged
fix: use correct delimiter on credit card zero values#1280zachgoll merged 1 commit intomaybe-finance:mainfrom
zachgoll merged 1 commit intomaybe-finance:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After recent fixes, the credit card view displays 0 by default on Minimum Payment and Annual Fee. However, the format is wrong. On zero values, the two digits after the delimiter are the decimals, and this is the current behaviour on other sections, like the dashboard.
For example, this is correct:
But this is not:
This PR resolves this issue, the credit card Minimum Payment and Annual Fee now display the correct delimiter on empty values:
I haven't seen any issues related to this, so I can't link one.
First time contributing and first time using ruby, I'll be happy to hear about your feedback.
Cheers.