Skip to content
This repository was archived by the owner on Jul 27, 2025. It is now read-only.

Basic account onboarding#1328

Merged
zachgoll merged 2 commits intomainfrom
zachgoll/sync-fixes
Oct 18, 2024
Merged

Basic account onboarding#1328
zachgoll merged 2 commits intomainfrom
zachgoll/sync-fixes

Conversation

@zachgoll
Copy link
Contributor

Allows a user to select the "mode" their account's are in:

CleanShot.2024-10-18.at.16.43.59.mp4

Also includes a few bug fixes around syncing.

<% end %>
<% else %>
<%= render "accounts/accountables/valuations", account: account %>
<% end %>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will need to come back around and clean a lot of this markup up. Lots of duplication across the accountable views


assert_equal 1000, new_account.balance
assert_equal [ 1250, 1000, 1000, 1000 ], new_account.balances.chronological.map(&:balance)
end
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validates bug when there is a transaction at an earlier date than the first valuation

@zachgoll zachgoll merged commit 263d65e into main Oct 18, 2024
@zachgoll zachgoll deleted the zachgoll/sync-fixes branch October 18, 2024 21:18
@Muzosh
Copy link

Muzosh commented Oct 30, 2024

@zachgoll

I'm confused. What if I want to use both the way it was before? I.e. adding transactions for personal transaction logging, but also update value based on current's date account appreciation? This is the main reason I chose to use Maybe from other financial managers.

Was this intentionally removed?

The account onboarding offers "Balance only" or "Transactions", suggesting that Transactions would also include Balance input.

Edit: I can see that I can still "update" the value by going into account edit:
image
But I would argue that this is somewhat cumbersome. I also can't edit the added balance value's date.

@Muzosh
Copy link

Muzosh commented Oct 30, 2024

I would also argue that this splitting accounts into two modes is even more confusing. Let's say I created the account above, with "today's balance" 1 CZK. I then change my mind and convert this account from balance mode to transactions mode and add some transactions on the same day.

The value is not updated because the "today's balance" is still overwriting it.

I guess this is intented (although I could again argue that I added transaction after I updated today's balance on the same day) but now user has even lower chance of figuring out what is going on since he thinks his account is in "transactions only" mode.

If the transactions and current balance modes still play role in the balance calculation (where current balance gets obviously priority based on date), why hide those two behind "choosing account mode" GUI?

@Muzosh
Copy link

Muzosh commented Oct 30, 2024

Also if the account is in "balance only" mode, I can still successfully import transactions. However, after import it gets immediately overwritten by new balance entry which was automatically created with the same value as previous entry for some reason. I don't think this behavior enhance user's ability to know what's going on with their balance.

@jakubkottnauer
Copy link
Contributor

I was just thinking about the same thing today. I believe a solution here might be introducing a third value tracking mode called "Advanced" which would be a combination of Balance and Transaction tracking mode (= basically the old behavior).

What do you think @zachgoll?

@zachgoll
Copy link
Contributor Author

I was just thinking about the same thing today. I believe a solution here might be introducing a third value tracking mode called "Advanced" which would be a combination of Balance and Transaction tracking mode (= basically the old behavior).

What do you think @zachgoll?

This is in the works already! It will just be a general "Activity View"

@zachgoll
Copy link
Contributor Author

Working on an update that will look like this, which we sourced quite a bit of feedback on in Discord:

image

@Muzosh
Copy link

Muzosh commented Nov 21, 2024

@zachgoll I just updated my instance and I'm super satisfied with this activity window. It solves all the issues I have written above :) Good job!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants