This repository was archived by the owner on Jul 27, 2025. It is now read-only.
Feature | Filter on uncategorized transactions#1359
Merged
zachgoll merged 3 commits intomaybe-finance:mainfrom Oct 25, 2024
bruno-costanzo:1354-feature-filter-on-uncategorized-transactions
Merged
Feature | Filter on uncategorized transactions#1359zachgoll merged 3 commits intomaybe-finance:mainfrom bruno-costanzo:1354-feature-filter-on-uncategorized-transactions
zachgoll merged 3 commits intomaybe-finance:mainfrom
bruno-costanzo:1354-feature-filter-on-uncategorized-transactions
Conversation
zachgoll
approved these changes
Oct 24, 2024
Contributor
zachgoll
left a comment
zachgoll
left a comment
There was a problem hiding this comment.
Thanks for the contribution @bruno-costanzo! Everything looks good to me.
You'll just need to fix those lint errors and then we can merge: bin/rubocop -f github -a
Contributor
Author
|
done @zachgoll |
bruno-costanzo
deleted the
1354-feature-filter-on-uncategorized-transactions
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
In the transaction index, in the filter by category, it is not possible to filter those transactions that do not have any assigned category.
What?
Test
When filtering only on uncategorized transactions, these should appear and those with a category should not appear. When adding a category, both those without and those with a category should appear.
Screenshot
co-author @nicogaldamez