This repository was archived by the owner on Jul 27, 2025. It is now read-only.
Allow custom column separator for CSV parsing in uploads controller#1470
Merged
zachgoll merged 2 commits intomaybe-finance:mainfrom Nov 18, 2024
acflint:fix-csv-import
Merged
Allow custom column separator for CSV parsing in uploads controller#1470zachgoll merged 2 commits intomaybe-finance:mainfrom acflint:fix-csv-import
zachgoll merged 2 commits intomaybe-finance:mainfrom
acflint:fix-csv-import
Conversation
Contributor
|
@acflint disregard my comment on the other PR that was closed. This looks good! |
Contributor
Author
|
@zachgoll I can fix the failing specs, if you'd like. Let me know. |
Contributor
|
@acflint yep, that would be great. Looks like we just need to pass |
Contributor
Author
|
@zachgoll done 👍🏻 |
Contributor
Author
|
I know it's small, but after almost 10 years of being a dev, this is the first OSS contribution I've had merged. So that's pretty cool :) Thanks @zachgoll! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for this issue: https://github.com/maybe-finance/maybe/issues/1462
csv_valid?wasn't using the submittedcol_separgument, so semicolon separated CSVs were failing to be validated.