Skip to content
This repository was archived by the owner on Jul 27, 2025. It is now read-only.

FIX: correct display of percentages#1622

Merged
zachgoll merged 4 commits intomaybe-finance:mainfrom
MrTob:fix/savings-rate-calculation
Jan 17, 2025
Merged

FIX: correct display of percentages#1622
zachgoll merged 4 commits intomaybe-finance:mainfrom
MrTob:fix/savings-rate-calculation

Conversation

@MrTob
Copy link
Contributor

@MrTob MrTob commented Jan 15, 2025 •
edited by zachgoll
Loading

Fixes #1619

zachgoll
zachgoll suggested changes Jan 16, 2025
View reviewed changes
@MrTob MrTob marked this pull request as draft January 17, 2025 10:09
@MrTob MrTob marked this pull request as ready for review January 17, 2025 10:15
@MrTob
Copy link
Contributor Author

MrTob commented Jan 17, 2025

@zachgoll
I have changed the code, the calculation is always the same (0.xx). Only in the view the number is multiplied by 100.

@zachgoll zachgoll merged commit ae9287e into maybe-finance:main Jan 17, 2025
5 checks passed
@MrTob MrTob deleted the fix/savings-rate-calculation branch January 17, 2025 16:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@zachgoll zachgoll zachgoll requested changes

@Synxsystemtool Synxsystemtool Synxsystemtool approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: Savings Rate calculation is wrong

3 participants

@MrTob @zachgoll @Synxsystemtool