Conversation
|
@zachgoll can you please approve the workflow and review. |
This comment was marked as duplicate.
This comment was marked as duplicate.
|
@goldenstein64 would you mind opening a new issue for this? I agree with your suggestion, but since it applies to all of our modals / drawers in the app, it's probably worth a standalone issue. |
0ec9ba9 to
a0ccd52
Compare
simplescreenrecorder-2025-02-18_05.07.03.mp4 |
simplescreenrecorder-2025-02-19_22.05.57.mp4 |
zachgoll
left a comment
There was a problem hiding this comment.
Overall looking a lot better! Core flow works great.
Before we merge, I think there are a few general "cleanup" items to address (several mentioned in comments):
Model validation / migration
Currently, the Category class allows nil for a category. Per @justinfar comments about the shapes icon being our default, we'll need to:
- Add a default value for
lucide_iconofshapeson theCategorytable - Add a NOT NULL constraint on
lucide_icon
Edge Cases in UI
- When you edit a subcategory, users can change the color to be different than the parent. This is because we have
before_create :inherit_color_from_parentin the model, but really, we need this to bebefore_committo cover both create + update flows + hide the color option in the UI if it is editing a subcategory. - When a user selects a preset color, then choose a custom color, the preset color remains selected in the UI (see video below):
CleanShot.2025-02-19.at.15.01.50.mp4
zachgoll
left a comment
There was a problem hiding this comment.
After all comments are addressed and merge conflicts resolved, we'll run the tests and get this merged.
Functionality looks good!
Signed-off-by: Syed Bariman Jan <syedbarimanjan@gmail.com>
zachgoll
left a comment
There was a problem hiding this comment.
Code looks good! Looks like there is a failing check, so once resolved we're good to merge.
Signed-off-by: Syed Bariman Jan <syedbarimanjan@gmail.com>
Signed-off-by: Syed Bariman Jan <syedbarimanjan@gmail.com>
|
@zachgoll resolved the failing check and merged with main to resolve conflicts. |
|
@syedbarimanjan great, nice work! Let me know if you have any issues with the bounty payment. |
* resolve git issue * Add new category flow * Improve contrast checker * make error message small * update ui to match figma design * realign color picker * changes * rename color picker controller to new category controller * cleanup code * cleanup code * resize and realign icon avatar * Fix js lint errors Signed-off-by: Syed Bariman Jan <syedbarimanjan@gmail.com> --------- Signed-off-by: Syed Bariman Jan <syedbarimanjan@gmail.com>
A video showing the changes in action:
simplescreenrecorder-2025-02-13_19.34.10.online-video-cutter.com.mp4
Fixes #1734
/claim #1734