You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Jul 27, 2025. It is now read-only.
The changes in #1823 introduced a regression where if a user had a parent category with zero transactions assigned to it while there were transactions assigned to one or more of its subcategories, the parent category summed to 0.
This is because the totals query filters out any categories with no transactions. This PR fixes this by ensuring that all family categories are included in the PeriodTotals response of the IncomeStatement.
@Foiler25 is there a chance Umbrel has not yet updated your app to the latest version? Can you confirm that the latest deploy is on v0.4.3?
This is working fine on both the hosted and self-hosted version for me so we'll need some more info to diagnose.
Hi @zachgoll after digging a bit deeper, the version that was published on Umbrel says it is 0.4.3 but within Maybe it is showing it currently running 0.4.1, apologies for the mistake, I will reach out through the appropriate channels for Umbrel instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes in #1823 introduced a regression where if a user had a parent category with zero transactions assigned to it while there were transactions assigned to one or more of its subcategories, the parent category summed to 0.
This is because the totals query filters out any categories with no transactions. This PR fixes this by ensuring that all family categories are included in the
PeriodTotalsresponse of theIncomeStatement.