Skip to content
This repository was archived by the owner on Jul 27, 2025. It is now read-only.

Fix parent category sums in budget#1894

Merged
zachgoll merged 1 commit intomainfrom
1837-budget-parent-category-does-not-include-sums-of-subcategories
Feb 24, 2025
Merged

Fix parent category sums in budget#1894
zachgoll merged 1 commit intomainfrom
1837-budget-parent-category-does-not-include-sums-of-subcategories

Conversation

@zachgoll
Copy link
Contributor

The changes in #1823 introduced a regression where if a user had a parent category with zero transactions assigned to it while there were transactions assigned to one or more of its subcategories, the parent category summed to 0.

This is because the totals query filters out any categories with no transactions. This PR fixes this by ensuring that all family categories are included in the PeriodTotals response of the IncomeStatement.

@zachgoll zachgoll linked an issue Feb 24, 2025 that may be closed by this pull request
@zachgoll zachgoll merged commit f5ff533 into main Feb 24, 2025
5 checks passed
@zachgoll zachgoll deleted the 1837-budget-parent-category-does-not-include-sums-of-subcategories branch February 24, 2025 17:51
@Foiler25
Copy link

Foiler25 commented Mar 1, 2025

Still having this issue in v0.4.3, nothing attached to the parent category, everything in sub-categories.

image

Running self-hosted on Umbrel.

pranav7 pushed a commit to pranav7/maybe that referenced this pull request Mar 2, 2025
@zachgoll
Copy link
Contributor Author

zachgoll commented Mar 3, 2025

@Foiler25 is there a chance Umbrel has not yet updated your app to the latest version? Can you confirm that the latest deploy is on v0.4.3?

This is working fine on both the hosted and self-hosted version for me so we'll need some more info to diagnose.

@Foiler25
Copy link

Foiler25 commented Mar 3, 2025

@Foiler25 is there a chance Umbrel has not yet updated your app to the latest version? Can you confirm that the latest deploy is on v0.4.3?

This is working fine on both the hosted and self-hosted version for me so we'll need some more info to diagnose.

Hi @zachgoll after digging a bit deeper, the version that was published on Umbrel says it is 0.4.3 but within Maybe it is showing it currently running 0.4.1, apologies for the mistake, I will reach out through the appropriate channels for Umbrel instead.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Budget parent category does not include sums of subcategories

2 participants