✨ [oip-#3442] Implement storybook for prosemirror editors #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefrado
force-pushed
the
3442-frontend-coverage
branch
from
d10cf4b to
80d1344
Compare
stefrado
force-pushed
the
3442-frontend-coverage
branch
2 times, most recently
from
9cd67b5 to
c378eb7
Compare
stefrado
force-pushed
the
3442-frontend-coverage
branch
from
c378eb7 to
2b25a83
Compare
stefrado
force-pushed
the
3442-frontend-coverage
branch
from
97324f1 to
ff11171
Compare
jiromaykin
requested changes
Nov 6, 2025
jiromaykin
left a comment
jiromaykin
left a comment
There was a problem hiding this comment.
An impressive amount of stories, though my browser can hardly handle it. It takes such a long while to load the Storybook stories, wondering why that is. Since this does not seem to be a problem when running the rich text-editors in Django.
| - name: Install dependencies | ||
| run: npm ci | ||
|
|
||
| # - name: Get Playwright version |
There was a problem hiding this comment.
These are all commented out - is this for documentation only? Or not needed at all?
| // All nodes and marks enabled | ||
| allowedNodes: Object.values(NodeType), | ||
| allowedMarks: Object.values(MarkType), | ||
| resize: "both", |
There was a problem hiding this comment.
These resize controls don't seem to do anything in none of the stories?
So the whole list with:
- both
- horizontal
- vertical
- block
- inline
- none
| resize: { | ||
| control: "radio", | ||
| options: [ | ||
| "both", |
There was a problem hiding this comment.
What effect should we see from these?
| expectedJSON = baseBlockquoteJSONContent; | ||
| editor = await waitForEditor(canvasElement); | ||
| blockquoteBtn = await canvas.findByTitle("Change to block quote"); | ||
| // styleDropdown = await canvas.findByText("Style"); |
| ["caption", ["string|null"], "The caption of the image"], | ||
| ], | ||
| }, | ||
| // TODO [WIP] |
There was a problem hiding this comment.
Will you need a new PR for this? :-) then its fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement multiple tools to have as much frontend coverage as possible:
Current coverage
Storybook preview