fix: unify update detection for commit-based extensions#251
Merged
Conversation
The VS Code extension's checkUpdate() reimplemented update detection with only semver comparison, missing commit-based updates entirely. Extensions installed from a commit (no GitHub releases) never showed updates in the tree view even when latestCommit changed in the registry. Replace the manual comparison loop with a call to the core library's checkForUpdates(), which handles both semver and commit-based updates. Export getRegistryUrl() and getCacheTTL() from extensionDetails.ts so the tree data provider can pass consistent settings to the core.
Move latestVersions reset after successful checkForUpdates() call so that a network or registry failure does not clear previously known update information from the tree view badge.
mcanouil
added
the
Type: Enhancement 💡
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
checkForUpdates(), which handles both semver and commit-based comparisons.latestCommitchanges in the registry.getRegistryUrl()andgetCacheTTL()fromextensionDetails.tsto pass consistent settings to the core.Fixes #231