fix: remove proactive GitHub session acquisition#252
Merged
Conversation
Remove the VSCode GitHub OAuth session check that ran before every command, which prompted users to sign in unnecessarily for public registry operations. Authentication is now exclusively reactive, handled by handleAuthError when 401/403 errors occur. The getAuthConfig function now only checks manual token (SecretStorage) and environment variables. The GetAuthConfigOptions interface is removed as it is no longer needed.
mcanouil
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getAuthConfig()that prompted users to sign in before every command, even for public registry operations.getAuthConfig()now only checks manual token (SecretStorage) and environment variables.handleAuthError()on 401/403 errors.GetAuthConfigOptionsinterface.