fix: correct element-attributes type and harden schema cache#258
Merged
fix: correct element-attributes type and harden schema cache#258
Conversation
- Change elementAttributes type from flat Record<string, FieldDescriptor> to grouped Record<string, Record<string, FieldDescriptor>> matching the actual _schema.yml structure (class-name -> attributes). - Make SchemaCache.get() exception-safe by catching errors from malformed schema files and returning null instead of propagating. - Add Array.isArray guard in parseSchemaContent to reject YAML arrays at root level. - Standardise Array.isArray guards across all normaliseSchema sections. - Add tests for array/scalar YAML rejection and cache error handling. - Wrap tempDir2 cleanup in try/finally in invalidateAll test.
mcanouil
added
the
Type: Enhancement 💡
mcanouil
added
the
Type: Enhancement 💡
mcanouil
added
Type: Bug 🐛
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
elementAttributestype from flatRecord<string, FieldDescriptor>to groupedRecord<string, Record<string, FieldDescriptor>>matching the actual_schema.ymlstructure where attributes are nested under CSS class or element type keys (e.g.,_any,panel,card).SchemaCache.get()exception-safe by catching errors from malformed schema files and returningnull, preventing one broken_schema.ymlfrom crashing the tree view, completions, or diagnostics.Array.isArrayguard inparseSchemaContentto reject YAML arrays at root level.Array.isArrayguards across allnormaliseSchemasections for consistency.Test plan
tsc --noEmit).