Conversation
… on backspace Use SnippetString instead of plain strings in adjustForValuePosition so VS Code's increaseIndentPattern does not double the indentation when completing keys after a colon. Add a debounced onDidChangeTextDocument listener that re-triggers the suggest widget on single-character deletions, since backspace cannot be registered as a trigger character.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SnippetStringinstead of plain strings inadjustForValuePositionto prevent VS Code'sincreaseIndentPatternfrom adding extra indentation when completing keys after a colon.onDidChangeTextDocumentlistener to re-trigger the suggest widget on backspace, since backspace cannot be a trigger character.Test plan
_quarto.yml, typeextensions:\n modal:, place cursor aftermodal:, trigger completion, accept an option key. The key should appear at 4 spaces of indentation (not 6)._quarto.yml, start typing an option key under an extension, press backspace. The suggest widget should re-appear.npx tsc --noEmit,npx eslint src/, andnpx prettier --check "src/**/*.ts"all pass.