Conversation
mcanouil
added
Type: Enhancement 💡
…mage attributes
Add `{` as a trigger character for the element attribute completion
provider so completions appear automatically when opening a Pandoc
attribute block.
Recognise `)` before `{` in the attribute parser to detect link and
image attribute contexts (`[text](url){` and `{`).
mcanouil
force-pushed
the
feat/element-attribute-trigger-brace
branch
from
6861641 to
85eaf33
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
{as a trigger character for the element attribute completion provider, so completions appear automatically when opening a Pandoc attribute block (e.g.::: {,]{,`{`).)before{inisPandocAttributeContextto detect link ([text](url){) and image ({) attribute contexts, mapped to"Span".getAttributeBoundsandparseAttributeAtPositionfor link/image syntax.Test plan
npx tsc --noEmitpasses.npx eslint src/passes.npx prettier --check "src/**/*.ts"passes.npm testpasses (332 passing; 10 pre-existing failures inactivate.test.js).::: {in a.qmdfile and verify completions appear automatically.[text]{and verify completions appear automatically.`code`{and verify completions appear automatically.{and verify completions appear automatically.{in plain text (not after a Pandoc element) and verify no completions appear.