Skip to content

fix: use notification action buttons, fix path traversal check, and clean up#268

Merged
mcanouil merged 1 commit intomainfrom
fix/codebase-audit
Feb 16, 2026
Merged

fix: use notification action buttons, fix path traversal check, and clean up#268
mcanouil merged 1 commit intomainfrom
fix/codebase-audit

Conversation

@mcanouil
Copy link
Copy Markdown
Owner

Summary

  • Replace markdown command links in notification messages with VS Code action buttons via showMessageWithLogs, since VS Code notifications do not render markdown.
  • Fix checkPathTraversal to split on path separators before checking for .. segments, preventing false positives on filenames containing that substring.
  • Replace fs.existsSync with async fs.promises.access in findExtensionRoot and findAllExtensionRoots.
  • Store latestVersion without @ prefix, fixing double-@ in the update-all command path.
  • Use node:crypto import prefix per Node.js conventions.
  • Update network tests to match new notification behaviour (action buttons instead of inline text).

Test plan

  • Verify 332 tests pass (10 pre-existing failures in stale activate.test.js are unrelated).
  • Verify lint passes cleanly.
  • Verify core package tests (420) pass.
  • Test notification messages show "Show Logs" action button.
  • Test extension update commands produce correct repo@version format.

…lean up

Replace markdown command links in notification messages with proper
VS Code action buttons via showMessageWithLogs, since VS Code
notifications do not render markdown.

Fix checkPathTraversal to split on path separators before checking
for ".." segments, preventing false positives on filenames containing
that substring.

Replace fs.existsSync with async fs.promises.access in findExtensionRoot
and findAllExtensionRoots.

Store latestVersion without "@" prefix and add it at formatting sites
to fix double-"@" in update-all command.

Use "node:crypto" import prefix per Node.js conventions.
@mcanouil mcanouil self-assigned this Feb 16, 2026
@mcanouil mcanouil added the Type: Bug 🐛 Issues related to bugs, errors, or mistakes label Feb 16, 2026
@mcanouil mcanouil merged commit 889c4f6 into main Feb 16, 2026
7 checks passed
@mcanouil mcanouil deleted the fix/codebase-audit branch February 16, 2026 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Bug 🐛 Issues related to bugs, errors, or mistakes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant