fix: use notification action buttons, fix path traversal check, and clean up#268
Merged
fix: use notification action buttons, fix path traversal check, and clean up#268
Conversation
…lean up Replace markdown command links in notification messages with proper VS Code action buttons via showMessageWithLogs, since VS Code notifications do not render markdown. Fix checkPathTraversal to split on path separators before checking for ".." segments, preventing false positives on filenames containing that substring. Replace fs.existsSync with async fs.promises.access in findExtensionRoot and findAllExtensionRoots. Store latestVersion without "@" prefix and add it at formatting sites to fix double-"@" in update-all command. Use "node:crypto" import prefix per Node.js conventions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
showMessageWithLogs, since VS Code notifications do not render markdown.checkPathTraversalto split on path separators before checking for..segments, preventing false positives on filenames containing that substring.fs.existsSyncwith asyncfs.promises.accessinfindExtensionRootandfindAllExtensionRoots.latestVersionwithout@prefix, fixing double-@in the update-all command path.node:cryptoimport prefix per Node.js conventions.Test plan
activate.test.jsare unrelated).repo@versionformat.