fix: suppress suggest menu when no completions available#276
Merged
Conversation
Add shouldRetriggerSuggest pre-check in yamlPosition.ts that verifies the cursor is in a completable context (root level, extensions, or format key paths) before re-triggering the suggest widget on backspace. Schema definition files retain the previous behaviour of always re-triggering within YAML regions.
Use getYamlIndentLevel on the line prefix up to the cursor position so that blank-line indent trimming in getYamlKeyPath receives the true indentation depth rather than a potentially larger column value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
shouldRetriggerSuggestpre-check inyamlPosition.tsthat verifies the cursor is in a completable context (root level,extensions, orformatkey paths) before re-triggering the suggest widget on backspace._schema.yml) retain the previous behaviour of always re-triggering within YAML regions.title: My title.Test plan
shouldRetriggerSuggestcovering YAML, QMD, and out-of-region scenarios._quarto.ymlwithtitle: My title, backspace at end produces no popup.extensions:\n modal:, backspace re-triggers suggestions._schema.ymlbackspace behaviour unchanged.