fix: guard against false linting diagnostics with CRLF line endings#304
Merged
fix: guard against false linting diagnostics with CRLF line endings#304
Conversation
…301) JavaScript's `.` regex metacharacter does not match `\r`. The opening fence regex in `getCodeBlockRanges` failed on lines with trailing `\r` from CRLF endings, so no code blocks were detected. This caused curly braces and `=` signs inside fenced code blocks to be flagged as attribute blocks, producing false `spaces-around-equals` diagnostics. Strip trailing `\r` before regex matching while preserving the raw line length for offset calculations. Add `overlapsCodeBlock` helper that checks both endpoints of a match against code block ranges.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #301.
JavaScript's
.regex metacharacter does not match\r.The opening fence regex in
getCodeBlockRangesfailed on lines with trailing\rfrom CRLF endings, so no code blocks were detected.This caused curly braces and
=signs inside fenced code blocks to be flagged as attribute blocks, producing falsespaces-around-equalsdiagnostics.Strip trailing
\rbefore regex matching while preserving the raw line length for offset calculations.Add an
overlapsCodeBlockhelper that checks both endpoints of a match against code block ranges.Eleven new CRLF-specific tests cover
getCodeBlockRanges,isInCodeBlockRange, andextractBlocks.