-
Notifications
You must be signed in to change notification settings - Fork 231
[VIS] Add Correlation Matrix to Visual Vocabulary #1511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
for more information, see https://pre-commit.ci
| name="Correlation", | ||
| pages=pages.correlation.pages, | ||
| incomplete_pages=[IncompletePage("Correlation matrix")], | ||
| # IncompletePage("Correlation matrix", "correlation"), # Completed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
incomplete_pages is currently required argument and app does not run without it. You have two options.
- pass in empty list
incomplete_pages=[]or - make
incomplete_pagesoptional:
- Step 1: add import
from dataclasses import dataclass, field - Step 2: replace ChartGroup` dataclass with the below code (line 34 in this file)
import
@dataclass
class ChartGroup:
"""Represents a group of charts like "Deviation"."""
name: str
pages: list[vm.Page]
intro_text: str
incomplete_pages: list[IncompletePage] = field(default_factory=list) # not required if ChartGroup complete
icon: str = "" # ALL_CHART_GROUP is the only one that doesn't require an icon.
nadijagraca
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @datascienceio 👋
Thank you for your PR. With this PR, the correlation chart group will be fully completed, which makes it our first completed chart group. 🙌
I’ve requested a few changes in the review. Please address them and feel free to request a re-review afterward.
vizro-core/examples/visual-vocabulary/pages/examples/correlation_matrix.py
Outdated
Show resolved
Hide resolved
vizro-core/examples/visual-vocabulary/pages/examples/correlation_matrix.py
Outdated
Show resolved
Hide resolved
vizro-core/examples/visual-vocabulary/pages/examples/correlation_matrix.py
Outdated
Show resolved
Hide resolved
|
Hi Nadija, Thank you for the information. Kind regards |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
I have made the changes mentioned in the review and am writing to request a re-review. Kind regards |
For just adding the fig definition instead of page definition, this may have resulted in an error regarding the PyCafe link running. To confirm, I am reverting this code back to the vm.page format to see if the error is resolved.
for more information, see https://pre-commit.ci
Description
Adds Correlation Matrix Visualisation to the Visual Vocabulary.
Notice
I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":