Skip to content

Conversation

@datascienceio
Copy link

Description

Adds Correlation Matrix Visualisation to the Visual Vocabulary.

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

    • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
    • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorized to submit this contribution on behalf of the original creator(s) or their licensees.
    • I certify that the use of this contribution as authorized by the Apache 2.0 license does not violate the intellectual property rights of anyone else.
    • I have not referenced individuals, products or companies in any commits, directly or indirectly.
    • I have not added data or restricted code in any commits, directly or indirectly.

@datascienceio datascienceio changed the title Add Correlation Matrix to Visual Vocabulary [VIS] Add Correlation Matrix to Visual Vocabulary Nov 30, 2025
name="Correlation",
pages=pages.correlation.pages,
incomplete_pages=[IncompletePage("Correlation matrix")],
# IncompletePage("Correlation matrix", "correlation"), # Completed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

incomplete_pages is currently required argument and app does not run without it. You have two options.

  1. pass in empty list incomplete_pages=[] or
  2. make incomplete_pages optional:
  • Step 1: add import from dataclasses import dataclass, field
  • Step 2: replace ChartGroup` dataclass with the below code (line 34 in this file)
    import
@dataclass
class ChartGroup:
    """Represents a group of charts like "Deviation"."""

    name: str
    pages: list[vm.Page]
    intro_text: str
    incomplete_pages: list[IncompletePage] = field(default_factory=list)  # not required if ChartGroup complete
    icon: str = ""  # ALL_CHART_GROUP is the only one that doesn't require an icon.

Copy link
Contributor

@nadijagraca nadijagraca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @datascienceio 👋

Thank you for your PR. With this PR, the correlation chart group will be fully completed, which makes it our first completed chart group. 🙌

I’ve requested a few changes in the review. Please address them and feel free to request a re-review afterward.

@datascienceio
Copy link
Author

Hi Nadija,

Thank you for the information.

Kind regards

@datascienceio
Copy link
Author

I have made the changes mentioned in the review and am writing to request a re-review. Kind regards

datascienceio and others added 4 commits December 5, 2025 21:47
For just adding the fig definition instead of page definition, this may have resulted in an error regarding the PyCafe link running. To confirm, I am reverting this code back to the vm.page format to see if the error is resolved.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants