schema: Require that a single note isn’t inside an array#3090
Merged
Elchi3 merged 4 commits intomdn:masterfrom Jan 9, 2019
Merged
schema: Require that a single note isn’t inside an array#3090Elchi3 merged 4 commits intomdn:masterfrom
Elchi3 merged 4 commits intomdn:masterfrom
Conversation
Elchi3
added
the
schema
Member
|
Do you have thoughts on #195 ? |
Contributor
Author
|
That allowing single‑element arrays in one context and disallowing them in another is rather inconsistent and we should either allow or forbid them in both contexts. |
Member
|
I think we've more or less settled on forbidding single-element arrays, so I think we should accept this PR. It needs a rebase now, though. |
Contributor
Author
|
review?(@Elchi3): I have now resolved merge conflicts and fixed the build errors (please merge this before more issues arise). |
Elchi3
requested changes
Jan 8, 2019
test/sample-data.json
Outdated
| "notes": [ | ||
| "A single note in an array" | ||
| ] | ||
| "notes": "A single note in an array" |
Contributor
Author
There was a problem hiding this comment.
That’s because I did a regex replace on the whole repository, and forgot to check for this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the
notesfield behave the same way as the browser support statement array.review?(@Elchi3)