fix(upower): resolve clippy warnings and remove dead code#658
Open
wayneColt wants to merge 1 commit intomecha-org:pre-releasefrom
Open
fix(upower): resolve clippy warnings and remove dead code#658wayneColt wants to merge 1 commit intomecha-org:pre-releasefrom
wayneColt wants to merge 1 commit intomecha-org:pre-releasefrom
Conversation
Replace fallible conversions with infallible From impls where the conversion cannot fail. Remove unused import and unnecessary .into() calls. Clean up commented-out code blocks. cargo clippy -p upower now passes with zero warnings.
Author
|
Happy to adjust if needed — just ran clippy on a few crates while reading through the shell architecture. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clean up the upower crate to pass cargo clippy with zero warnings.
Verified:
cargo clippy -p upowerpasses clean.